-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review85413
-----------------------------------------------------------


Do you want to wire up module loading in src/slave/resource_estimator.cpp in 
this patch, or in a follow up? :)


src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34662/#comment137018>

    When you resolved the conflict by wrapping the test resource estimator in 
the new namespace, you shouldn't need 'mesos::internal::tests::ModuleID::'



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34662/#comment137019>

    Let's align like in master_allocator_tests.cpp



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/34662/#comment136975>

    Reinsert newline please :)



src/tests/resource_estimator.hpp
<https://reviews.apache.org/r/34662/#comment137020>

    Max line length for comments is 70 cols :)



src/tests/resource_estimator.hpp
<https://reviews.apache.org/r/34662/#comment137026>

    Does it make sense to use the 'slave' namespace instead of introducing a 
new one?



src/tests/resource_estimator.hpp
<https://reviews.apache.org/r/34662/#comment137021>

    End with period :)



src/tests/resource_estimator.hpp
<https://reviews.apache.org/r/34662/#comment137022>

    Sorry Bartek, I know I asked for the string version of the factory. I 
thought we could get rid of the flags based one. Let's kill this and use the 
slave flags in test_resource_estimator_module.cpp 
    
    Can you kill this, if you have the 'factory' below?


- Niklas Nielsen


On May 27, 2015, 9:34 a.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34662/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 9:34 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2650
>     https://issues.apache.org/jira/browse/MESOS-2650
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added *ResourceEstimator* (RE) module interface. 
> Added *TestResourceEstimator* example module. (Test *ResourceEstimator* 
> module)
> Moved *TestResourceEstimator* to seperate file from *tests/mesos.hpp*
> Changed *oversubscription_tests* to be typed_tested (for normal RE and RE 
> module)
> 
> NOTE: The example modules were good enough for other modules' unit tests, 
> however RE had to be extended - to push particular *Resources* to slave.
> 
> In future if we implement https://issues.apache.org/jira/browse/MESOS-2764, 
> we will be able to inject stubed *Resources* in better way.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/resource_estimator.hpp PRE-CREATION 
>   src/Makefile.am 814468e3c5c750a6649b5eeb7c7f945f9e025c19 
>   src/examples/test_resource_estimator_module.cpp PRE-CREATION 
>   src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be 
>   src/tests/mesos.hpp b8f7a2f9236166e42421d926718af8d45e857eba 
>   src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8 
>   src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29 
>   src/tests/oversubscription_tests.cpp 
> 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 
>   src/tests/resource_estimator.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34662/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to