> On May 28, 2015, 5:40 p.m., Adam B wrote: > > Do you clearly understand why this change is needed? I didn't understand > > after just reading the JIRA, and had to ask the reporter(s). Mesosphere is > > hosting the Mesos UI(s) underneath the DCOS UI behind a reverse proxy, so > > that `http://<dcos_host:port>/mesos` shows the Mesos UI, and > > `http://<dcos_host:port>/mesos/help/foo` should show the appropriate help > > path. > > > > How did you test this? Please fill out the "Testing" section appropriately.
FWIW - this has nothing to do with DCOS and/or reverse proxy: just run Mesos on your localhost, and you can see the bug in action. Essentially, the URL generating logic is faulty, and adds and extra `/help` segment to the URL path for the JSON payload. Launch master, open `localhost:5050/help` in your browser and click any of the links; you'll see a generic 'page not found' - in the URL address, remove the `/help` segment and you'll see the JSON payload just fine. > On May 28, 2015, 5:40 p.m., Adam B wrote: > > 3rdparty/libprocess/src/help.cpp, line 140 > > <https://reviews.apache.org/r/34655/diff/1/?file=971486#file971486line140> > > > > Why does this '/help/' need to be removed? because it's wrong - it shouldn't be there. - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34655/#review85571 ----------------------------------------------------------- On May 28, 2015, 7:54 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34655/ > ----------------------------------------------------------- > > (Updated May 28, 2015, 7:54 a.m.) > > > Review request for mesos, Adam B, Marco Massenzio, and Michael Lunøe. > > > Bugs: MESOS-2748 > https://issues.apache.org/jira/browse/MESOS-2748 > > > Repository: mesos > > > Description > ------- > > Use relative url in /help generated links point > > > Diffs > ----- > > 3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c > > Diff: https://reviews.apache.org/r/34655/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
