----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34545/#review85693 -----------------------------------------------------------
Looks good. Just some wording suggestions. docs/allocation-module.md <https://reviews.apache.org/r/34545/#comment137410> technically, the "default" is "hierarchical DRF" (role, then framework). docs/allocation-module.md <https://reviews.apache.org/r/34545/#comment137411> s/To get a custom allocation logic in Mesos, one needs to/To use a custom allocator in Mesos, one must/ docs/allocation-module.md <https://reviews.apache.org/r/34545/#comment137412> Capitalize "Implement" s/defined/as defined/ docs/allocation-module.md <https://reviews.apache.org/r/34545/#comment137413> "[Wrap] the allocator implementation in a module and load it in the Mesos master" docs/allocation-module.md <https://reviews.apache.org/r/34545/#comment137422> s/the language Mesos is written in/the same language in which Mesos is written/ (those dang dangling prepositions) s/to the actual allocator/to an actual allocator/ docs/allocation-module.md <https://reviews.apache.org/r/34545/#comment137423> s/As almost every Mesos component/Like most Mesos components/ s/wrap your...allocator into/wrap your...allocator in a/ docs/allocation-module.md <https://reviews.apache.org/r/34545/#comment137424> Sorters define the order in which roles or frameworks should be offered resources by taking... Could you also replace "roles" and "frameworks" with different hierarchy layers? docs/allocation-module.md <https://reviews.apache.org/r/34545/#comment137425> s/When/Once/ docs/allocation-module.md <https://reviews.apache.org/r/34545/#comment137426> s/into/in/ docs/allocation-module.md <https://reviews.apache.org/r/34545/#comment137427> Maybe give bogus names/emails so they know that Apache Mesos doesn't have to own/maintain every module. docs/configuration.md <https://reviews.apache.org/r/34545/#comment137429> Does it actually default to the value "HierarchicalDRF" or just blank, which implicitly means to use HierarchicalDRF? docs/modules.md <https://reviews.apache.org/r/34545/#comment137430> The Mesos master's _allocator_ periodically determines which framework(s) should be offered the cluster's available resources. docs/modules.md <https://reviews.apache.org/r/34545/#comment137431> s/to Mesos master/to the Mesos master/ docs/modules.md <https://reviews.apache.org/r/34545/#comment137432> s/as an allocator/as the allocator/ There can be only one! docs/modules.md <https://reviews.apache.org/r/34545/#comment137433> `file://<path-to-external-allocator>.json` is a little confusing, especially if there are multiple modules that need to be loaded. Maybe just call it `modules.json` give an example json? - Adam B On May 26, 2015, 3:37 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34545/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 3:37 a.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, and Niklas Nielsen. > > > Bugs: MESOS-2596 > https://issues.apache.org/jira/browse/MESOS-2596 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/allocation-module.md bca54b01b80708c8265708aa9e2ef4a02fe64228 > docs/configuration.md 5a41477d81eceff98eef4c2ba096448fc408ff3a > docs/modules.md 835c195745421938a5dc86c3c7d5777e02d660b7 > > Diff: https://reviews.apache.org/r/34545/diff/ > > > Testing > ------- > > Rendered the docs in MacDown and github. > > > Thanks, > > Alexander Rukletsov > >
