> On May 29, 2015, 9:01 a.m., Adam B wrote: > > docs/allocation-module.md, line 7 > > <https://reviews.apache.org/r/34545/diff/3/?file=971645#file971645line7> > > > > technically, the "default" is "hierarchical DRF" (role, then framework).
Indeed, good point! > On May 29, 2015, 9:01 a.m., Adam B wrote: > > docs/allocation-module.md, lines 147-148 > > <https://reviews.apache.org/r/34545/diff/3/?file=971645#file971645line147> > > > > Maybe give bogus names/emails so they know that Apache Mesos doesn't > > have to own/maintain every module. Good idea. > On May 29, 2015, 9:01 a.m., Adam B wrote: > > docs/configuration.md, line 224 > > <https://reviews.apache.org/r/34545/diff/3/?file=971646#file971646line224> > > > > Does it actually default to the value "HierarchicalDRF" or just blank, > > which implicitly means to use HierarchicalDRF? We opted not to use blank fields, the allocator name should be always specified (like authenticator or master detector). > On May 29, 2015, 9:01 a.m., Adam B wrote: > > docs/modules.md, line 130 > > <https://reviews.apache.org/r/34545/diff/3/?file=971647#file971647line130> > > > > s/as an allocator/as the allocator/ > > There can be only one! Currently yes, but would be nice to have multiple one day! Will fix, thanks. > On May 29, 2015, 9:01 a.m., Adam B wrote: > > docs/modules.md, line 135 > > <https://reviews.apache.org/r/34545/diff/3/?file=971647#file971647line135> > > > > `file://<path-to-external-allocator>.json` is a little confusing, > > especially if there are multiple modules that need to be loaded. Maybe just > > call it `modules.json` give an example json? let's go for `modules-including-allocator.json`. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34545/#review85693 ----------------------------------------------------------- On May 26, 2015, 10:37 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34545/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 10:37 a.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, and Niklas Nielsen. > > > Bugs: MESOS-2596 > https://issues.apache.org/jira/browse/MESOS-2596 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/allocation-module.md bca54b01b80708c8265708aa9e2ef4a02fe64228 > docs/configuration.md 5a41477d81eceff98eef4c2ba096448fc408ff3a > docs/modules.md 835c195745421938a5dc86c3c7d5777e02d660b7 > > Diff: https://reviews.apache.org/r/34545/diff/ > > > Testing > ------- > > Rendered the docs in MacDown and github. > > > Thanks, > > Alexander Rukletsov > >
