----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/#review85769 -----------------------------------------------------------
3rdparty/libprocess/include/process/http.hpp <https://reviews.apache.org/r/33793/#comment137544> add a '.' at the end of comments 3rdparty/libprocess/include/process/http.hpp <https://reviews.apache.org/r/33793/#comment137545> same here 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/33793/#comment137550> We should be consistent here, either test both cases for all examples or just one. Also test an all upper-case example too? - Isabel Jimenez On May 20, 2015, 7:09 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33793/ > ----------------------------------------------------------- > > (Updated May 20, 2015, 7:09 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-328 > https://issues.apache.org/jira/browse/MESOS-328 > > > Repository: mesos > > > Description > ------- > > HTTP headers should be considered case-insensitive. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > bba62b393dc863e724cb602b1504eb6517ae9730 > 3rdparty/libprocess/src/encoder.hpp > f1b91cf4fc215b6cc8f73285408384269a9bb894 > 3rdparty/libprocess/src/tests/http_tests.cpp > d29cd29d8c0544671a09d204ca8ba4f24340e2de > > Diff: https://reviews.apache.org/r/33793/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >
