----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/#review87745 -----------------------------------------------------------
Ship it! Just some minor style items, I'll clean them up and get this committed for you. 3rdparty/libprocess/include/process/http.hpp <https://reviews.apache.org/r/33793/#comment140159> Two lines between top-level definitions. 3rdparty/libprocess/include/process/http.hpp <https://reviews.apache.org/r/33793/#comment140162> Extra whitespace here to match the rest of our code: ``` $ grep -R "operator ()" src src/master/allocator/sorter/drf/sorter.cpp:bool DRFComparator::operator () (const Client& client1, const Client& client2) src/master/allocator/sorter/drf/sorter.hpp: virtual bool operator () (const Client& client1, const Client& client2); src/master/registrar.hpp: Try<bool> operator () ( ``` 3rdparty/libprocess/include/process/http.hpp <https://reviews.apache.org/r/33793/#comment140160> Two lines between top-level definitions. 3rdparty/libprocess/include/process/http.hpp <https://reviews.apache.org/r/33793/#comment140163> Ditto here. 3rdparty/libprocess/include/process/http.hpp <https://reviews.apache.org/r/33793/#comment140161> Two lines between top-level definitions. 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/33793/#comment140156> Remember to put 2 lines between top level definitions. 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/33793/#comment140158> s/HeaderInsensitiveCase/CaseInsensitiveHeaders/ 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/33793/#comment140157> Ditto here. - Ben Mahler On June 1, 2015, 9:02 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33793/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 9:02 a.m.) > > > Review request for mesos, Ben Mahler and Isabel Jimenez. > > > Bugs: MESOS-328 > https://issues.apache.org/jira/browse/MESOS-328 > > > Repository: mesos > > > Description > ------- > > HTTP headers should be considered case-insensitive. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > bba62b393dc863e724cb602b1504eb6517ae9730 > 3rdparty/libprocess/src/encoder.hpp > f1b91cf4fc215b6cc8f73285408384269a9bb894 > 3rdparty/libprocess/src/tests/http_tests.cpp > d29cd29d8c0544671a09d204ca8ba4f24340e2de > > Diff: https://reviews.apache.org/r/33793/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >
