-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34362/#review85959
-----------------------------------------------------------


Looks good, but it's missing a few performance tricks we've used in other json 
model() functions, to reduce the json construction time, especially for large 
clusters. We should do some quick benchmarking on a cluster with thousands of 
(simulated) executors to see how much overhead this adds to state.json.


src/master/http.cpp
<https://reviews.apache.org/r/34362/#comment137800>

    Can you reserve the size of the executors array like we've done for 
tasks/offers (See MESOS-2353)? I suppose you'll have to loop through all the 
slaves to count each of their executor lists, but that's probably still less 
expensive than growing the executors array each time.



src/master/http.cpp
<https://reviews.apache.org/r/34362/#comment137802>

    Nit: Please insert blank line between these two like in other similar 
blocks.



src/master/http.cpp
<https://reviews.apache.org/r/34362/#comment137801>

    std::move(executors);


- Adam B


On May 18, 2015, 10:41 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34362/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 10:41 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2743
>     https://issues.apache.org/jira/browse/MESOS-2743
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Include ExecutorInfos in master/state.json
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp afce7fea334c7bfa57efc48c413bf906a2ebde32 
>   src/common/http.cpp 2ac7fba7a3aac913540f1b09768777393b79284a 
>   src/master/http.cpp 7fa47a9fa2f5667631169876964dccf7fdcc172e 
>   src/slave/http.cpp b5e77b09435e50db5231a2b32faf76dab91dae54 
> 
> Diff: https://reviews.apache.org/r/34362/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to