reviews  

Messages by Thread

• • Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests. Andrei Sekretenko
  • Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests. Mesos Reviewbot
  • Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests. Andrei Sekretenko
  • Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests. Mesos Reviewbot
• Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call. Andrei Sekretenko
  • Re: Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call. Mesos Reviewbot
  • Re: Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call. Mesos Reviewbot
  • Re: Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call. Benjamin Mahler
• Review Request 72841: Added offer constraints to the `GetFrameworks` protobuf. Andrei Sekretenko
  • Re: Review Request 72841: Added offer constraints to the `GetFrameworks` protobuf. Benjamin Mahler
• Review Request 72840: Exposed offer constraints via the `/state` and `/frameworks` endpoints. Andrei Sekretenko
  • Re: Review Request 72840: Exposed offer constraints via the `/state` and `/frameworks` endpoints. Benjamin Mahler
  • Re: Review Request 72840: Exposed offer constraints via the `/state` and `/frameworks` endpoints. Andrei Sekretenko
  • Re: Review Request 72840: Exposed offer constraints via the `/state` and `/frameworks` endpoints. Andrei Sekretenko
• Review Request 72839: Added `OfferConstraints` to `struct Framework` in the master. Andrei Sekretenko
  • Re: Review Request 72839: Added `OfferConstraints` to `struct Framework` in the master. Benjamin Mahler
  • Re: Review Request 72839: Added `OfferConstraints` to `struct Framework` in the master. Andrei Sekretenko
• Review Request 72838: Moved framework update out of `connectAndActivateRecoveredFramework`. Andrei Sekretenko
  • Re: Review Request 72838: Moved framework update out of `connectAndActivateRecoveredFramework`. Benjamin Mahler
• Review Request 72830: Added a regression test for MESOS-9609. Benjamin Mahler
  • Re: Review Request 72830: Added a regression test for MESOS-9609. Benjamin Mahler
  • Re: Review Request 72830: Added a regression test for MESOS-9609. Benjamin Mahler
  • Re: Review Request 72830: Added a regression test for MESOS-9609. Greg Mann
  • Re: Review Request 72830: Added a regression test for MESOS-9609. Benjamin Mahler
  • Re: Review Request 72830: Added a regression test for MESOS-9609. Mesos Reviewbot
• Review Request 72831: Fixed a CHECK failure in master during agent removal. Benjamin Mahler
  • Re: Review Request 72831: Fixed a CHECK failure in master during agent removal. Benjamin Mahler
  • Re: Review Request 72831: Fixed a CHECK failure in master during agent removal. Greg Mann
• Review Request 72832: Avoided unnecessary [] map operators in the master. Benjamin Mahler
  • Re: Review Request 72832: Avoided unnecessary [] map operators in the master. Mesos Reviewbot
  • Re: Review Request 72832: Avoided unnecessary [] map operators in the master. Benjamin Mahler
  • Re: Review Request 72832: Avoided unnecessary [] map operators in the master. Greg Mann
  • Re: Review Request 72832: Avoided unnecessary [] map operators in the master. Benjamin Mahler
• Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`. Andrei Sekretenko
  • Re: Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`. Benjamin Mahler
  • Re: Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`. Andrei Sekretenko
  • Re: Review Request 72833: Removed `bool operator==(const FrameworkInfo&, const FrameworkInfo&)`. Andrei Sekretenko
• Review Request 72829: Moved the `volume/csi` isolator's root dir under work dir. Qian Zhang
  • Re: Review Request 72829: Moved the `volume/csi` isolator's root dir under work dir. Mesos Reviewbot
  • Re: Review Request 72829: Moved the `volume/csi` isolator's root dir under work dir. Greg Mann
• Review Request 72826: Augmented `MasterAPITest.FrameworksEvent` to verify reregistration time. Andrei Sekretenko
  • Re: Review Request 72826: Augmented `MasterAPITest.FrameworksEvent` to verify reregistration time. Benjamin Mahler
• Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo. Andrei Sekretenko
  • Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo. Benjamin Mahler
  • Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo. Mesos Reviewbot
  • Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo. Mesos Reviewbot
  • Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo. Andrei Sekretenko
• Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Andrei Sekretenko
  • Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Benjamin Mahler
  • Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Andrei Sekretenko
  • Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Benjamin Mahler
  • Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Andrei Sekretenko
  • Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Benjamin Mahler
  • Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Andrei Sekretenko
  • Re: Review Request 72824: Eliminated redundant update broadcasts in UPDATE_FRAMEWORK. Andrei Sekretenko
• Review Request 72823: Made UpdateFramework tests not rely on redundant FRAMEWORK_UPDATED. Andrei Sekretenko
  • Re: Review Request 72823: Made UpdateFramework tests not rely on redundant FRAMEWORK_UPDATED. Benjamin Mahler
• Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Andrei Sekretenko
  • Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Benjamin Mahler
  • Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Andrei Sekretenko
  • Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Benjamin Mahler
  • Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Andrei Sekretenko
  • Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Andrei Sekretenko
  • Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Benjamin Mahler
  • Re: Review Request 72822: Extracted FrameworkInfo comparison logic from tests. Andrei Sekretenko
• Review Request 72820: Relaxed unknown volume check when unpublishing volumes. Qian Zhang
  • Re: Review Request 72820: Relaxed unknown volume check when unpublishing volumes. Greg Mann
• Review Request 72816: Fixed broken authorization in the CSI server. Greg Mann
  • Re: Review Request 72816: Fixed broken authorization in the CSI server. Qian Zhang
  • Re: Review Request 72816: Fixed broken authorization in the CSI server. Greg Mann
• Review Request 72806: Added a test for 'volume/csi' isolator recovery. Greg Mann
  • Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery. Mesos Reviewbot
  • Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery. Greg Mann
  • Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery. Mesos Reviewbot
  • Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
  • Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
  • Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
  • Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
  • Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Qian Zhang
  • Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
  • Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
  • Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
  • Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Qian Zhang
  • Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
  • Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Greg Mann
  • Re: Review Request 72806: Added tests for 'volume/csi' isolator recovery. Qian Zhang
• Review Request 72805: Added a test helper for CSI volumes. Greg Mann
  • Re: Review Request 72805: Added a test helper for CSI volumes. Qian Zhang
  • Re: Review Request 72805: Added a test helper for CSI volumes. Greg Mann
  • Re: Review Request 72805: Added a test helper for CSI volumes. Greg Mann
  • Re: Review Request 72805: Added a test helper for CSI volumes. Qian Zhang
• Review Request 72803: Added a new agent flag `--csi_volume_chown`. Qian Zhang
• Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator. Qian Zhang
  • Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator. Mesos Reviewbot
  • Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator. Greg Mann
  • Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator. Qian Zhang
  • Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator. Qian Zhang
  • Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator. Greg Mann
  • Re: Review Request 72804: Enabled CSI volume access for non-root users. Qian Zhang
• Review Request 72799: Fixed a data race in the CSI server. Greg Mann
  • Re: Review Request 72799: Fixed a bug in CSI server initialization. Greg Mann
  • Re: Review Request 72799: Fixed a bug in CSI server initialization. Qian Zhang
  • Re: Review Request 72799: Fixed a bug in CSI server initialization. Greg Mann
• Review Request 72794: Added a test for discarding image pull on discard of getting image. Andrei Sekretenko
  • Re: Review Request 72794: Added a test for discarding image pull on discard of getting image. Mesos Reviewbot
  • Re: Review Request 72794: Added a test for discarding image pull on discard of getting image. Qian Zhang
• Review Request 72793: Added discarding a future returned by get() into the docker store test. Andrei Sekretenko
  • Re: Review Request 72793: Added discarding a future returned by get() into the docker store test. Qian Zhang
• Review Request 72792: Fixed typos in the name of `PullingSameImageSimutanuously` test. Andrei Sekretenko
  • Re: Review Request 72792: Fixed typos in the name of `PullingSameImageSimutanuously` test. Qian Zhang
• Review Request 72791: Reverted removal of the PullingSameImageSimutanuously test. Andrei Sekretenko
  • Re: Review Request 72791: Reverted removal of the PullingSameImageSimutanuously test. Qian Zhang
• Review Request 72790: Deduplicated concurrent image pulls by docker store. Andrei Sekretenko
  • Re: Review Request 72790: Deduplicated concurrent image pulls by docker store. Qian Zhang
  • Re: Review Request 72790: Deduplicated concurrent image pulls by docker store. Andrei Sekretenko
• Review Request 72789: Checkpointed CSI volume state in stringified JSON. Qian Zhang
  • Re: Review Request 72789: Checkpointed CSI volume state in stringified JSON. Qian Zhang
  • Re: Review Request 72789: Checkpointed CSI volume state in stringified JSON. Mesos Reviewbot
  • Re: Review Request 72789: Checkpointed CSI volume state in stringified JSON. Greg Mann
  • Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way. Qian Zhang
  • Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way. Qian Zhang
  • Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way. Qian Zhang
  • Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way. Mesos Reviewbot
  • Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way. Greg Mann
  • Re: Review Request 72789: Refactored state recovery in `volume/csi` isolator. Qian Zhang
  • Re: Review Request 72789: Refactored state recovery in `volume/csi` isolator. Qian Zhang
• Review Request 72788: Added a work around in v1 volume manager for Portworx CSI plugin. Qian Zhang
  • Re: Review Request 72788: Added a work around in v1 volume manager for Portworx CSI plugin. Mesos Reviewbot
  • Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field. Qian Zhang
  • Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field. Mesos Reviewbot
  • Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field. Greg Mann
  • Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field. Qian Zhang
• Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72786: Implemented regex-based offer constraints. Benjamin Mahler
  • Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72786: Implemented regex-based offer constraints. Benjamin Mahler
  • Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72786: Implemented regex-based offer constraints. Benjamin Mahler
  • Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72786: Implemented regex-based offer constraints. Benjamin Mahler
  • Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72786: Implemented regex-based offer constraints. Benjamin Mahler
  • Re: Review Request 72786: Implemented regex-based offer constraints. Andrei Sekretenko
• Review Request 72787: Added basic tests for regexp-based constraints. Andrei Sekretenko
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Andrei Sekretenko
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Benjamin Mahler
  • Re: Review Request 72787: Added basic tests for regexp-based constraints. Mesos Reviewbot
• Review Request 72782: Added RE2 to the CMake build. Andrei Sekretenko
  • Re: Review Request 72782: Added RE2 to the CMake build. Andrei Sekretenko
  • Re: Review Request 72782: Added RE2 to the CMake build. Benjamin Mahler
• Review Request 72784: Added protobuf messages for regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72784: Added protobuf messages for regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72784: Added protobuf messages for regex-based offer constraints. Benjamin Mahler
  • Re: Review Request 72784: Added protobuf messages for regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72784: Added protobuf messages for regex-based offer constraints. Andrei Sekretenko
  • Re: Review Request 72784: Added protobuf messages for regex-based offer constraints. Benjamin Mahler
  • Re: Review Request 72784: Added protobuf messages for regex-based offer constraints. Andrei Sekretenko
• Review Request 72785: Introduced a weak_ptr-based cache abstraction. Andrei Sekretenko
  • Re: Review Request 72785: Introduced a weak_ptr-based cache abstraction. Mesos Reviewbot
  • Re: Review Request 72785: Introduced a weak_ptr-based cache abstraction. Mesos Reviewbot
• Review Request 72783: Added RE2 to the automake build. Andrei Sekretenko
  • Re: Review Request 72783: Added RE2 to the automake build. Andrei Sekretenko
  • Re: Review Request 72783: Added RE2 to the automake build. Benjamin Mahler
• Review Request 72781: Updated volume manager to support user specified target path root. Qian Zhang
  • Re: Review Request 72781: Updated volume manager to support user specified target path root. Mesos Reviewbot
  • Re: Review Request 72781: Updated volume manager to support user specified target path root. Greg Mann
• Review Request 72779: Initialized plugins lazily in the CSI server. Greg Mann
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Mesos Reviewbot
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Qian Zhang
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Greg Mann
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Qian Zhang
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Greg Mann
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Mesos Reviewbot
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Mesos Reviewbot
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Mesos Reviewbot
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Greg Mann
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Qian Zhang
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Greg Mann
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Greg Mann
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Qian Zhang
  • Re: Review Request 72779: Initialized plugins lazily in the CSI server. Mesos Reviewbot

• Earlier messages
• Later messages