-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34894/#review86048
-----------------------------------------------------------



include/mesos/mesos.proto
<https://reviews.apache.org/r/34894/#comment137909>

    This page doesn't seem to document these statistics. Is there a more 
relevant page?



include/mesos/mesos.proto
<https://reviews.apache.org/r/34894/#comment137912>

    queue_length?



include/mesos/mesos.proto
<https://reviews.apache.org/r/34894/#comment137911>

    rate_bps? or is this how it's named in the kernel?



include/mesos/mesos.proto
<https://reviews.apache.org/r/34894/#comment137907>

    What's possible here: can more than one be present or is it only any one? 
What's the difference between these?
    
    If it's only one then why not flatten this and include a type?



include/mesos/mesos.proto
<https://reviews.apache.org/r/34894/#comment137908>

    This shouldn't be named including isolator. If the previously flatten is 
possible then perhaps NetworkControlStatistics?


- Ian Downes


On June 1, 2015, 9:40 a.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34894/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 9:40 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add new message for Traffic Control statistics
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5cf81e20bc77288eb4c183722c608827b5000cb4 
> 
> Diff: https://reviews.apache.org/r/34894/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to