> On June 6, 2015, 12:10 a.m., Ian Downes wrote: > > include/mesos/mesos.proto, line 533 > > <https://reviews.apache.org/r/34894/diff/3/?file=977694#file977694line533> > > > > What's the set of possible ids? If it's the well-defined set that we > > discussed offline then we should probably enumerate them? @jieyu, thoughts? > > Otherwise we'll be string matching on id. For example (with not very good > > naming): > > ``` > > message TrafficControlStatistics { > > enum Type { > > tx_internal = 1; > > tx_external = 2; > > rx_internal = 3; > > rx_external = 4; > > } > > required Type type = 1; > > optional ... > > } > > ```
Ian, I think it's hard to enumerate eventually. What if in the future, we want to change the qdisc hierarchy to be more sophisticated (e.g., more intermediate filters/qdiscs), and we want to get statistics for all of them? I just feel that it'll be very hard to enumerate. Also, disk usage for volumes, we can not enumerate anyway. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86875 ----------------------------------------------------------- On June 3, 2015, 9:54 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34894/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 9:54 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Repository: mesos > > > Description > ------- > > Add new message for Traffic Control statistics > > > Diffs > ----- > > include/mesos/mesos.proto 6186c92c6fe9cf8fa136d93d5af43e0377406baf > > Diff: https://reviews.apache.org/r/34894/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
