----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/#review86057 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp <https://reviews.apache.org/r/34529/#comment137923> FYI I've also shortened the test: ``` TEST(OptionTest, NonConstReference) { Option<string> s = string("hello"); s.get() += " world"; EXPECT_EQ("hello world", s.get()); } ``` Was there some value in having the 'copy' variable? - Ben Mahler On May 31, 2015, 4:39 a.m., Mark Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34529/ > ----------------------------------------------------------- > > (Updated May 31, 2015, 4:39 a.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-2716 > https://issues.apache.org/jira/browse/MESOS-2716 > > > Repository: mesos > > > Description > ------- > > Add non-const reference version of Option<T>::get. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp > ea79b501d9ed7b7da9636ce9c9c590738a586993 > 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp > 7ae3b8ffc5df7f8442e72b1a10d50c3f5c373d8c > > Diff: https://reviews.apache.org/r/34529/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Mark Wang > >
