> On May 29, 2015, 8:21 p.m., Joris Van Remoortere wrote:
> > Hey Mark,
> > Thanks for your work!
> > I left some comments, but this looks good to me once you fix them.
> > Will you be making a follow up review that gets rid of the cases you used 
> > as justification for this change?
> > 
> > Joris

Hi Joris,

Thanks for the review. I agreed with you to pull this extra function out to 
another patch. I am not sure how to make a new JIRA and assgin to myself... 
Could you guide me where and how?

Mark


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34529/#review85792
-----------------------------------------------------------


On May 31, 2015, 1:13 a.m., Mark Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34529/
> -----------------------------------------------------------
> 
> (Updated May 31, 2015, 1:13 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2716
>     https://issues.apache.org/jira/browse/MESOS-2716
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add non-const reference version of Option<T>::get.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> ea79b501d9ed7b7da9636ce9c9c590738a586993 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 
> 7ae3b8ffc5df7f8442e72b1a10d50c3f5c373d8c 
> 
> Diff: https://reviews.apache.org/r/34529/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Mark Wang
> 
>

Reply via email to