----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review86436 -----------------------------------------------------------
src/hook/manager.cpp <https://reviews.apache.org/r/30339/#comment138427> Don't you need to acquire the mutex here? - Niklas Nielsen On June 1, 2015, 2:46 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30339/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 2:46 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Call hook manager only if hooks were specified on the commandline. > > > Diffs > ----- > > src/hook/manager.hpp 638e19f5062f070cd0ec94d830615a2c73fd357d > src/hook/manager.cpp 54b0d34b6e9f2f8a8cf7a6c2f5ded2f6ab6c6955 > src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d > src/slave/containerizer/containerizer.cpp > 4d66e767de1f877cb66b37826ba7c9d00639a7c0 > src/slave/slave.cpp 271cb03770cd08406054dfce35d0821475e49b05 > src/tests/hook_tests.cpp 3ffde6d6b2faeb5a8a40eb27c3b0a2b7f9ecd2b1 > > Diff: https://reviews.apache.org/r/30339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
