> On June 4, 2015, 3:39 a.m., Till Toenshoff wrote: > > src/tests/hook_tests.cpp, line 132 > > <https://reviews.apache.org/r/30339/diff/3/?file=975944#file975944line132> > > > > Could you please explain quickly on why this was ever working / is > > needed now?
Good point. As it turns out, we don't need these changes anymore since we explicitly do `HookManager::initialize(HOOK_MODULE_NAME)`. This forces the hooksAvailable() to always return true. Thanks for the catch! - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review86574 ----------------------------------------------------------- On June 15, 2015, 6:26 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30339/ > ----------------------------------------------------------- > > (Updated June 15, 2015, 6:26 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Call hook manager only if hooks were specified on the commandline. > > > Diffs > ----- > > src/hook/manager.hpp 638e19f5062f070cd0ec94d830615a2c73fd357d > src/hook/manager.cpp b43b91878cc9f0f5f5d081b9b3af0768c07c282b > src/master/master.cpp 0137c37a42d4f7a9057568a8cd7b662ed92be353 > src/slave/containerizer/containerizer.cpp > e995ce602261c18373ac09c823638c4a252cca86 > src/slave/slave.cpp 67732a40ef683cb0188425f0bba8fe8ab83e461c > > Diff: https://reviews.apache.org/r/30339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
