-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33241/#review86442
-----------------------------------------------------------



docs/home.md
<https://reviews.apache.org/r/33241/#comment138454>

    I would call this file monitoring because it talks about metrics and alerts.
    
    [Monitoring] /documentation/latest/monitoring/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138451>

    s/used/allocated/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138450>

    s/used/allocated/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138449>

    s/used/allocated/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138448>

    s/used/allocated/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138447>

    s/used/allocated/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138446>

    s/used/allocated/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138430>

    Number of tasks that were invalid.



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138431>

    There are also fine grained metrics about task lost reasons. 
    
    e.g:
    
     master/task_failed/source_slave/reason_memory_limit 
     
    It is worth documenting these.



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138436>

    s/aborted/terminated/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138438>

    s/used/allocated/
    
    this was a bad metric name. we will figure out how to rename it to 
allocated in the future.



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138440>

    s/used/allocated/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138441>

    s/used/allocated/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138442>

    s/used/allocated/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138444>

    s/used/allocated/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138445>

    s/used/allocated/



docs/metrics.md
<https://reviews.apache.org/r/33241/#comment138452>

    Can you add some basic alerts for slaves too like you did for master?


- Vinod Kone


On May 12, 2015, 8:43 p.m., Ricardo Cervera-Navarro wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33241/
> -----------------------------------------------------------
> 
> (Updated May 12, 2015, 8:43 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2621
>     https://issues.apache.org/jira/browse/MESOS-2621
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> docs: Add documentation on observability metrics.
> 
> 
> Diffs
> -----
> 
>   docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea 
>   docs/metrics.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33241/diff/
> 
> 
> Testing
> -------
> 
> - Previewed in markdown editor.
> - Replaced page content using the Element Inspector in Chrome to ensure that 
> the tables look good.
> 
> 
> File Attachments
> ----------------
> 
> mesosmetrics2.webarchive
>   
> https://reviews.apache.org/media/uploaded/files/2015/04/27/b89946c8-f709-4bca-b610-affd584c62f3__mesosmetrics2.webarchive
> 
> 
> Thanks,
> 
> Ricardo Cervera-Navarro
> 
>

Reply via email to