reviews
Thread
Date
Later messages
Messages by Thread
Re: Review Request 71977: Added systemd support to domain socket agent flag.
Mesos Reviewbot
Re: Review Request 71977: Added systemd support to domain socket agent flag.
Benjamin Bannier
Re: Review Request 71977: Added systemd support to domain socket agent flag.
Mesos Reviewbot
Review Request 71976: Added support for systemd socket activation API.
Benno Evers
Re: Review Request 71976: Added support for systemd socket activation API.
Benjamin Bannier
Re: Review Request 71833: Created unix domain socket on agent startup.
Benno Evers
Re: Review Request 71833: Created unix domain socket on agent startup.
Benjamin Bannier
Re: Review Request 71816: Added domain socket-related flags to Mesos agent.
Benno Evers
Re: Review Request 71816: Added domain socket-related flags to Mesos agent.
Benjamin Bannier
Re: Review Request 71816: Added domain socket-related flags to Mesos agent.
Benjamin Bannier
Re: Review Request 71816: Added domain socket-related flags to Mesos agent.
Benjamin Bannier
Re: Review Request 71815: Made the default executors connect via domain sockets if available.
Benno Evers
Re: Review Request 71815: Made the default executors connect via domain sockets if available.
Benjamin Bannier
Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.
Benno Evers
Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.
Benjamin Bannier
Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.
Benno Evers
Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.
Benjamin Bannier
Re: Review Request 71935: Added a new task status reason.
Greg Mann
Re: Review Request 71935: Added a new task status reason.
Mesos Reviewbot
Re: Review Request 71935: Added a new task status reason.
Qian Zhang
Review Request 71978: Updated all GET_* v1 master calls to be served in parallel.
Benjamin Mahler
Re: Review Request 71978: Updated all GET_* v1 master calls to be served in parallel.
Mesos Reviewbot
Re: Review Request 71978: Updated all GET_* v1 master calls to be served in parallel.
Andrei Sekretenko
Re: Review Request 71978: Updated all GET_* v1 master calls to be served in parallel.
Benjamin Mahler
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Greg Mann
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Greg Mann
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Greg Mann
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
Review Request 71971: Added special case to stout's handling of C++ attributes.
Benno Evers
Re: Review Request 71971: Added special case to stout's handling of C++ attributes.
Benjamin Bannier
Re: Review Request 71971: Added special case to stout's handling of C++ attributes.
Benno Evers
Re: Review Request 71971: Added special case to stout's handling of C++ attributes.
Benjamin Bannier
Re: Review Request 71971: Added special case to stout's handling of C++ attributes.
Benno Evers
Re: Review Request 71971: Added special case to stout's handling of C++ attributes.
Mesos Reviewbot
Re: Review Request 71952: WIP: Set resource limits when updating executor container.
Qian Zhang
Re: Review Request 71952: WIP: Set resource limits when updating executor container.
Qian Zhang
Re: Review Request 71952: WIP: Set resource limits when updating executor container.
Greg Mann
Re: Review Request 71952: WIP: Set resource limits when updating executor container.
Qian Zhang
Re: Review Request 71952: WIP: Set resource limits when updating executor container.
Qian Zhang
Re: Review Request 71952: Set resource limits when updating executor container.
Qian Zhang
Re: Review Request 71952: Set resource limits when updating executor container.
Greg Mann
Re: Review Request 71952: Set resource limits when updating executor container.
Greg Mann
Re: Review Request 71952: Set resource limits when updating executor container.
Greg Mann
Re: Review Request 71952: Set resource limits when updating executor container.
Qian Zhang
Re: Review Request 71952: Set resource limits when updating executor container.
Greg Mann
Re: Review Request 71952: Set resource limits when updating executor container.
Qian Zhang
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Greg Mann
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Greg Mann
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Qian Zhang
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Greg Mann
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Qian Zhang
Re: Review Request 71950: Updated containierzer's `update()` method to handle resource limits.
Greg Mann
Re: Review Request 71950: Updated containierzer's `update()` method to handle resource limits.
Qian Zhang
Re: Review Request 71950: Updated containierzer's `update()` method to handle resource limits.
Greg Mann
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Greg Mann
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Greg Mann
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Greg Mann
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Greg Mann
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
Re: Review Request 71944: Set container process's OOM score adjust.
Greg Mann
Re: Review Request 71943: WIP: Set container's `memory.limit_in_bytes` to its memory limit.
Greg Mann
Re: Review Request 71943: WIP: Set container's `memory.limit_in_bytes` to its memory limit.
Qian Zhang
Re: Review Request 71886: WIP: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Greg Mann
Re: Review Request 71886: WIP: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Qian Zhang
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
Re: Review Request 71865: Moved creating authorization Object out of `Master::authorizeSlave`.
Benjamin Mahler
Re: Review Request 71864: Moved creating authorization Object out of `Master::authorize*reserve`.
Benjamin Mahler
Re: Review Request 71864: Moved creating authorization Object out of `Master::authorize*reserve`.
Benjamin Mahler
Re: Review Request 71863: Moved creating authorization Object out of `Master::authorize*Volume`.
Benjamin Mahler
Re: Review Request 71862: Moved creating authorization Object out of `Master::authorize*Disk`.
Benjamin Mahler
Re: Review Request 71861: Moved creating authz Object out of `Master::authorizeResizeVolume`.
Benjamin Mahler
Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Andrei Budnik
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Mesos Reviewbot
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Mesos Reviewbot
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Qian Zhang
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Andrei Budnik
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Andrei Budnik
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Mesos Reviewbot
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Mesos Reviewbot
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Mesos Reviewbot
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Mesos Reviewbot
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Andrei Budnik
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Qian Zhang
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Qian Zhang
Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Mesos Reviewbot
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Mesos Reviewbot
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Mesos Reviewbot
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Mesos Reviewbot
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Greg Mann
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Qian Zhang
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Qian Zhang
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Greg Mann
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Greg Mann
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Qian Zhang
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Greg Mann
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Qian Zhang
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Qian Zhang
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Greg Mann
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Qian Zhang
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Qian Zhang
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Qian Zhang
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Greg Mann
Re: Review Request 71960: Added support for deprecated attribute to stout.
Benjamin Bannier
Review Request 71961: Added deprecated absolute() function for backwards compatibility.
Benno Evers
Re: Review Request 71961: Added deprecated absolute() function for backwards compatibility.
Benjamin Bannier
Later messages