reviews
Thread
Date
Later messages
Messages by Thread
Re: Review Request 72116: Fixed incorrect task count logging in master's agent draining logic.
Joseph Wu
Re: Review Request 72116: Fixed incorrect task count logging in master's agent draining logic.
Mesos Reviewbot
Review Request 72114: Removed remaining domain socket code from the Windows build.
Greg Mann
Re: Review Request 72114: Removed remaining domain socket code from the Windows build.
Greg Mann
Re: Review Request 72114: Removed remaining domain socket code from the Windows build.
Benjamin Bannier
Re: Review Request 72114: Removed remaining domain socket code from the Windows build.
Mesos Reviewbot
Review Request 72107: Fixed Windows command argument stringification.
Greg Mann
Re: Review Request 72107: Fixed Windows command argument stringification.
Benjamin Bannier
Re: Review Request 72107: Fixed Windows command argument stringification.
Mesos Reviewbot
Review Request 72097: Converted UPDATE_FRAMEWORK to synchronous authorization.
Andrei Sekretenko
Re: Review Request 72097: Converted UPDATE_FRAMEWORK to synchronous authorization.
Benjamin Mahler
Review Request 72091: Got rid of LocalAuthorizerProcess::authorize(...) method.
Andrei Sekretenko
Review Request 72095: Tied tracking framework state and connection state together.
Andrei Sekretenko
Re: Review Request 72095: Tied tracking framework state and connection state together.
Benjamin Mahler
Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.
Andrei Sekretenko
Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.
Benjamin Mahler
Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.
Andrei Sekretenko
Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.
Benjamin Mahler
Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.
Andrei Sekretenko
Review Request 72098: Converted ACCEPT to synchronous authorization.
Andrei Sekretenko
Re: Review Request 72098: Converted ACCEPT to synchronous authorization.
Andrei Sekretenko
Re: Review Request 72098: Converted ACCEPT to synchronous authorization.
Benjamin Mahler
Re: Review Request 72098: Converted ACCEPT to synchronous authorization.
Andrei Sekretenko
Review Request 72099: Removed code for tracking pending tasks.
Andrei Sekretenko
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
Re: Review Request 72099: Removed code for tracking pending tasks.
Benjamin Mahler
Re: Review Request 72099: Removed code for tracking pending tasks.
Benjamin Mahler
Re: Review Request 72099: Removed code for tracking pending tasks.
Andrei Sekretenko
Re: Review Request 72099: Removed code for tracking pending tasks.
Andrei Sekretenko
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
Re: Review Request 72099: Removed code for tracking pending tasks.
Benjamin Mahler
Re: Review Request 72099: Removed code for tracking pending tasks.
Andrei Sekretenko
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
Review Request 72096: Store per-framework ObjectApprovers.
Andrei Sekretenko
Re: Review Request 72096: Store per-framework ObjectApprovers.
Andrei Sekretenko
Re: Review Request 72096: Store per-framework ObjectApprovers.
Benjamin Mahler
Re: Review Request 72096: Store per-framework ObjectApprovers.
Andrei Sekretenko
Re: Review Request 72096: Store per-framework ObjectApprovers.
Benjamin Mahler
Re: Review Request 72096: Store per-framework ObjectApprovers.
Andrei Sekretenko
Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
Andrei Sekretenko
Re: Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
Benjamin Mahler
Re: Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
Benjamin Mahler
Re: Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
Andrei Sekretenko
Review Request 72094: Made `http`, `pid` and `heartbeater` of Framework private.
Andrei Sekretenko
Re: Review Request 72094: Made `http`, `pid` and `heartbeater` of Framework private.
Benjamin Mahler
Re: Review Request 72094: Made `http`, `pid` and `heartbeater` of `Framework` private.
Andrei Sekretenko
Re: Review Request 72094: Made `http`, `pid` and `heartbeater` of `Framework` private.
Andrei Sekretenko
Re: Review Request 72094: Made `http`, `pid` and `heartbeater` of `Framework` private.
Benjamin Mahler
Re: Review Request 72094: Made `http`, `pid` and `heartbeater` of `Framework` private.
Andrei Sekretenko
Review Request 72092: Added `ObjectApprover`s caching to the local authorizer.
Andrei Sekretenko
Review Request 72090: Introduced a weak_ptr-based cache abstraction.
Andrei Sekretenko
Re: Review Request 72090: Introduced a weak_ptr-based cache abstraction.
Benjamin Mahler
Review Request 72089: Introduced `provideObjectApprover(...)` authorizer interface.
Andrei Sekretenko
Re: Review Request 72089: Introduced `provideObjectApprover(...)` authorizer interface.
Benjamin Mahler
Re: Review Request 72089: Introduced `getApprover(...)` authorizer interface.
Andrei Sekretenko
Review Request 72087: Cleaned up agent capability validation and associated docs.
Greg Mann
Re: Review Request 72087: Cleaned up agent capability validation and associated docs.
Mesos Reviewbot
Re: Review Request 72087: Cleaned up agent capability validation and associated docs.
Qian Zhang
Review Request 72079: Added workaround for Docker repositories not providing scope/service.
Andrei Sekretenko
Re: Review Request 72079: Added workaround for Docker repositories not providing scope/service.
Qian Zhang
Re: Review Request 72079: Added workaround for Docker repositories not providing scope/service.
Andrei Sekretenko
Re: Review Request 72079: Added workaround for Docker repositories not providing scope/service.
Andrei Sekretenko
Re: Review Request 72079: Added workaround for Docker repositories not providing scope/service.
Qian Zhang
Review Request 72078: Factored out getting authorization server URI.
Andrei Sekretenko
Re: Review Request 72078: Factored out getting authorization server URI.
Qian Zhang
Re: Review Request 72078: Factored out getting authorization service URI.
Andrei Sekretenko
Re: Review Request 72078: Factored out getting authorization service URI.
Qian Zhang
Re: Review Request 72078: Factored out getting authorization service URI.
Andrei Sekretenko
Review Request 72080: Added test for fetch from repositories not providing scope/service.
Andrei Sekretenko
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Mesos Reviewbot
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Qian Zhang
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Andrei Sekretenko
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Mesos Reviewbot
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Mesos Reviewbot
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Qian Zhang
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Andrei Sekretenko
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Andrei Sekretenko
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Mesos Reviewbot
Review Request 72077: Factored out common code for building URIs on a repository host.
Andrei Sekretenko
Re: Review Request 72077: Factored out common code for building URIs on a repository host.
Qian Zhang
Re: Review Request 72077: Factored out common code for building URIs on a repository host.
Qian Zhang
Re: Review Request 72077: Factored out common code for building URIs on a repository host.
Andrei Sekretenko
Re: Review Request 72077: Factored out common code for building URIs on a registry host.
Qian Zhang
Re: Review Request 72077: Factored out common code for building URIs on a registry host.
Andrei Sekretenko
Re: Review Request 72077: Factored out common code for building URIs on a registry host.
Qian Zhang
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Qian Zhang
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Greg Mann
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Greg Mann
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Greg Mann
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Mesos Reviewbot
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Qian Zhang
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Greg Mann
Review Request 72070: Fixed the build on Windows.
Benjamin Bannier
Re: Review Request 72070: Fixed the build on Windows.
Mesos Reviewbot
Re: Review Request 72070: Fixed the build on Windows.
Greg Mann
Review Request 72068: Removed dead code from v1 API serialization changes.
Benjamin Mahler
Re: Review Request 72068: Removed dead code from v1 API serialization changes.
Mesos Reviewbot
Re: Review Request 72068: Removed dead code from v1 API serialization changes.
Andrei Sekretenko
Review Request 72064: Improved performance of v1 agent operator API GET_FRAMEWORKS call.
Benjamin Mahler
Re: Review Request 72064: Improved performance of v1 agent operator API GET_FRAMEWORKS call.
Benjamin Mahler
Re: Review Request 72064: Improved performance of v1 agent operator API GET_FRAMEWORKS call.
Andrei Sekretenko
Re: Review Request 72064: Improved performance of v1 agent operator API GET_FRAMEWORKS call.
Andrei Sekretenko
Review Request 72065: Improved performance of v1 agent operator API GET_EXECUTORS call.
Benjamin Mahler
Re: Review Request 72065: Improved performance of v1 agent operator API GET_EXECUTORS call.
Andrei Sekretenko
Re: Review Request 72065: Improved performance of v1 agent operator API GET_EXECUTORS call.
Benjamin Mahler
Review Request 72067: Improved performance of v1 agent operator API GET_STATE call.
Benjamin Mahler
Re: Review Request 72067: Improved performance of v1 agent operator API GET_STATE call.
Andrei Sekretenko
Review Request 72066: Improved performance of v1 agent operator API GET_TASKS call.
Benjamin Mahler
Re: Review Request 72066: Improved performance of v1 agent operator API GET_TASKS call.
Andrei Sekretenko
Re: Review Request 72066: Improved performance of v1 agent operator API GET_TASKS call.
Benjamin Mahler
Re: Review Request 72029: Changed termination logic of the default executor.
Andrei Budnik
Re: Review Request 72029: Changed termination logic of the default executor.
Mesos Reviewbot
Re: Review Request 72029: Changed termination logic of the default executor.
Greg Mann
Re: Review Request 72029: Changed termination logic of the default executor.
Andrei Budnik
Re: Review Request 72029: Changed termination logic of the default executor.
Greg Mann
Re: Review Request 72029: Changed termination logic of the default executor.
Greg Mann
Re: Review Request 72029: Changed termination logic of the default executor.
Qian Zhang
Re: Review Request 72029: Changed termination logic of the default executor.
Andrei Budnik
Re: Review Request 72029: Changed termination logic of the default executor.
Mesos Reviewbot
Re: Review Request 72029: Changed termination logic of the default executor.
Qian Zhang
Re: Review Request 72029: Changed termination logic of the default executor.
Andrei Budnik
Re: Review Request 72029: Changed termination logic of the default executor.
Qian Zhang
Re: Review Request 72029: Changed termination logic of the default executor.
Andrei Budnik
Re: Review Request 72029: Changed termination logic of the default executor.
Mesos Reviewbot
Re: Review Request 72029: Changed termination logic of the default executor.
Qian Zhang
Re: Review Request 72029: Changed logic of termination of the default executor.
Mesos Reviewbot
Re: Review Request 72017: SSL Socket: Added downgrade support.
Mesos Reviewbot
Re: Review Request 72017: SSL Socket: Added downgrade support.
Greg Mann
Review Request 72056: Improved performance of v1 agent operator API GetMetrics call.
Benjamin Mahler
Re: Review Request 72056: Improved performance of v1 agent operator API GetMetrics call.
Mesos Reviewbot
Re: Review Request 72056: Improved performance of v1 agent operator API GET_METRICS call.
Benjamin Mahler
Re: Review Request 72056: Improved performance of v1 agent operator API GET_METRICS call.
Andrei Sekretenko
Review Request 72055: Changed logic of termination of the Docker executor.
Andrei Budnik
Re: Review Request 72055: Changed logic of termination of the Docker executor.
Mesos Reviewbot
Re: Review Request 72055: Changed logic of termination of the Docker executor.
Qian Zhang
Re: Review Request 72055: Changed logic of termination of the Docker executor.
Vinod Kone
Re: Review Request 72055: Changed termination logic of the Docker executor.
Andrei Budnik
Re: Review Request 72055: Changed termination logic of the Docker executor.
Qian Zhang
Re: Review Request 72055: Changed termination logic of the Docker executor.
Andrei Budnik
Re: Review Request 72055: Changed termination logic of the Docker executor.
Qian Zhang
Re: Review Request 72055: Changed termination logic of the Docker executor.
Andrei Budnik
Re: Review Request 72055: Changed termination logic of the Docker executor.
Mesos Reviewbot
Re: Review Request 72055: Changed termination logic of the Docker executor.
Greg Mann
Re: Review Request 72055: Changed termination logic of the Docker executor.
Andrei Budnik
Re: Review Request 72055: Changed termination logic of the Docker executor.
Qian Zhang
Re: Review Request 72055: Changed termination logic of the Docker executor.
Andrei Budnik
Re: Review Request 72055: Changed termination logic of the Docker executor.
Qian Zhang
Re: Review Request 72055: Changed termination logic of the Docker executor.
Andrei Budnik
Re: Review Request 72055: Changed termination logic of the Docker executor.
Qian Zhang
Review Request 72054: Switched `verify-reviews.py` to use ubuntu-16.04-based image.
Benjamin Bannier
Re: Review Request 72054: Switched `verify-reviews.py` to use ubuntu-16.04-based image.
Andrei Budnik
Re: Review Request 67631: [WIP] Added non-const accessor for JSON values.
Benjamin Bannier
Re: Review Request 72018: Windows: Excluded some unix socket code.
Greg Mann
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Andrei Sekretenko
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Benjamin Mahler
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Andrei Sekretenko
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Benjamin Mahler
Re: Review Request 71782: Moved check on subscriber presences into subscribers.send.
Mesos Reviewbot
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Andrei Budnik
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Andrei Budnik
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Benjamin Bannier
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Andrei Budnik
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Mesos Reviewbot
Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits.
Qian Zhang
Re: Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits.
Greg Mann
Re: Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits.
Qian Zhang
Re: Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits.
Qian Zhang
Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Qian Zhang
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Qian Zhang
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Greg Mann
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Qian Zhang
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
Re: Review Request 72034: Sync'd whether an executor was generated to and from disk.
Andrei Sekretenko
Re: Review Request 72033: Decoupled detection of generated executors from Mesos install location.
Andrei Sekretenko
Re: Review Request 72035: Remembered whether an executor was agent-generated.
Mesos Reviewbot
Re: Review Request 72035: Remembered whether an executor was agent-generated.
Andrei Sekretenko
Later messages