> On June 2, 2015, 3:38 p.m., Marco Massenzio wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, lines 514-517 > > <https://reviews.apache.org/r/34943/diff/1/?file=976659#file976659line514> > > > > I'll admit I'm still a bith hazy about the new { } initializer, but > > could have this been: > > ``` > > char* argv[] = { (char*) "/path/to/program", > > (char*) "--name1=billy joel" }; > > ``` > > Benjamin Hindman wrote: > I just copied this code. Let me give this a test and if so I'll cleanup > the others too.
This is definitely cleaner and we should do it this way going forward so I'm going drop it here and follow up with a subsequent review that takes care of this, thanks for pointing it out! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34943/#review86225 ----------------------------------------------------------- On June 5, 2015, 2:48 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34943/ > ----------------------------------------------------------- > > (Updated June 5, 2015, 2:48 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Also refactored existing 'lambda::bind' arguments to use C++11 lambdas, > enabling us to get rid of our "loader" and "stringifier" functors. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 6ac2f04a6a1d8db1725972a3b4b46a0dd734566f > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp > 87606d860dea3235ec70d127d3379065d42dc90b > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > ee855da6128c2d671eb2fc7eaa2c0aab2341aebb > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/loader.hpp > 51d3ab020bd2bae1f12b66cac0da5383c813d5d7 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/stringifier.hpp > fda5ae1328a23a4371475652f921341dce7448d5 > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp > 80450185f60c5b273face490e0bb9e695b0cb984 > > Diff: https://reviews.apache.org/r/34943/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
