> On June 8, 2015, 2:37 a.m., Jojy Varghese wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 517
> > <https://reviews.apache.org/r/34943/diff/2/?file=979975#file979975line517>
> >
> >     style question: Why not use static array declaration :
> >     const char *args[] = {
> >         "/path/to/program",
> >         "blah"
> >     };
> >     
> >     and also make the function argument const char**?

For consistency, i.e., because the rest of this file does it this way. But I 
would love it if you did a sweep of this file and claned them all up to do it 
the way you proposed in a follow up review!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34943/#review86981
-----------------------------------------------------------


On June 11, 2015, 1:52 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34943/
> -----------------------------------------------------------
> 
> (Updated June 11, 2015, 1:52 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Also refactored existing 'lambda::bind' arguments to use C++11 lambdas, 
> enabling us to get rid of our "loader" and "stringifier" functors.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 6ac2f04a6a1d8db1725972a3b4b46a0dd734566f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 87606d860dea3235ec70d127d3379065d42dc90b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> ee855da6128c2d671eb2fc7eaa2c0aab2341aebb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/loader.hpp 
> 51d3ab020bd2bae1f12b66cac0da5383c813d5d7 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/stringifier.hpp 
> fda5ae1328a23a4371475652f921341dce7448d5 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 95b4b33b70c37640d97dff5d5724550d42048b76 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/open.hpp 
> 134453e91d39fd086baa9396ab42a002fed8b73e 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 
> 59cde89b5e035807a510b331b85a8cd48da36ae3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 
> 4485e41feb8320d2ec7251b8b894ce437f61addd 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp 
> cfe6d742560f50079fb1ed7346526d432615613c 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 
> 80450185f60c5b273face490e0bb9e695b0cb984 
>   3rdparty/libprocess/include/Makefile.am 
> d01880c66ca544d62d3ada1ea79c8045884858da 
>   3rdparty/libprocess/include/process/firewall.hpp 
> 16ed852d07344e53c6f9d30d4cd7d99e07c6606d 
>   3rdparty/libprocess/include/process/process.hpp 
> e70dd388601bd26fcc82f66e0cb95924da8a8c2f 
>   3rdparty/libprocess/src/process.cpp 
> aadd7bb0ae12b93336900c76d8d5aaa4421ea198 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 660af45e7fd45bdf5d43ad9aa54477fd94f87058 
>   Doxyfile 1b0a2beda1d9223eafd9d14d335c651eb4961a15 
>   docs/configuration.md aaf65bfa2848318c8d07c772ba2c521aa72c2677 
>   docs/engineering-principles-and-practices.md 
> 6babb929ead758ee5187d5fc5760d084876c3298 
>   docs/home.md ee3d3e9a417d75af776dad3ea9627d3c6d780dca 
>   docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e 
>   docs/powered-by-mesos.md 0ee763ffe32e6667e4ba708dd275d9f1b5116815 
>   include/mesos/containerizer/containerizer.proto 
> f16ccc89f83da28c413ccfa0687a06b7515a605c 
>   include/mesos/master/allocator.hpp 92de1af414321281b00eaa6f129e5e3e2c849448 
>   include/mesos/mesos.proto 7457ff11f6a55099ccb95beb2f0ccb9a2f7ccd87 
>   src/Makefile.am 10b190288425d735b116ed2dd3f040e871c5cb18 
>   src/cli/mesos-ps ae48c8cde31e90024381ed3e6e22ec3bc96560b6 
>   src/examples/no_executor_framework.cpp 
> 6c5c7d3121e3a2ea78f66dffdeaecb72cca6293c 
>   src/files/files.cpp 3cdd38a3c7122bd5e13c8928279d85ab1373a63e 
>   src/linux/routing/handle.hpp 052c7cc1a967797d245a275d08cc774f627398a5 
>   src/linux/routing/queueing/fq_codel.hpp 
> 18c53b416718c27045986d939bb85f9fec731ca5 
>   src/linux/routing/queueing/fq_codel.cpp 
> 446863391d1c6dd2f91f890596927a20ee59a35f 
>   src/main.dox d5b29cf96b18ba84ac39f1747c4a174a5bfbc2e1 
>   src/master/allocator/mesos/allocator.hpp 
> 6cfa04650d91a80211cfbc0809236f9438926c78 
>   src/master/allocator/mesos/hierarchical.hpp 
> c220ea673320d4d06403afa76f0eb9f3b7a4e5eb 
>   src/master/flags.hpp 55ed3a9ef84a39841305cca2ba6c5df45c1990e1 
>   src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 
>   src/master/main.cpp 1c33e3bf7baae45b1671f9566b4993f39d9f1294 
>   src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 
>   src/master/master.cpp e91e8815471b49d3c649470197d6da3f06de62fb 
>   src/master/metrics.hpp 3d389e68f22e3d1e00bde0db4e25f897c79a2316 
>   src/master/metrics.cpp d2489c8897fb2f2f21f021ac5e7a2ada7997ea06 
>   src/messages/flags.hpp 41be419ba5593a600aa0c6c411210fa4faa829a8 
>   src/messages/flags.proto 5400c92297f252734789982d21d7117ef4c57a57 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f 
>   src/slave/flags.hpp 6c24e56d15881b0e3aeec3d4824842cf57121fc6 
>   src/slave/flags.cpp 99142fb1cf9d1978df86fdbf612e656b8fe852a6 
>   src/slave/main.cpp c379243e01919a5ab30bb9dea1b738665ba4e746 
>   src/slave/slave.cpp 98036b2d5f2c765aef4a416c3cbc082df77ab3ac 
>   src/tests/master_contender_detector_tests.cpp 
> af6f15a8a85f2a292f5a64286aaa986f7dc29eff 
>   src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 
>   src/tests/no_executor_framework_test.sh 
> b5bb111ceb99d4dc836537516de57c1ba0582371 
>   src/tests/oversubscription_tests.cpp 
> 59cf07ef93460537ce1343793fd4a5d11d2ae242 
>   src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5 
>   src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0 
> 
> Diff: https://reviews.apache.org/r/34943/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to