> On June 5, 2015, 9:37 p.m., Vinod Kone wrote:
> > src/examples/no_executor_framework.cpp, line 219
> > <https://reviews.apache.org/r/34970/diff/2/?file=979734#file979734line219>
> >
> >     LOG(FATAL)? because this is not possible with a command executor?

Sure, this was to stay consistent with the other examples (e.g. 
persistent_volume_framework.cpp), but I'll change it.


> On June 5, 2015, 9:37 p.m., Vinod Kone wrote:
> > src/examples/no_executor_framework.cpp, line 253
> > <https://reviews.apache.org/r/34970/diff/2/?file=979734#file979734line253>
> >
> >     s/active/launched/ ?

This is all non-terminal (i.e. active) tasks. Launched seems to imply 
everything ever launched, no?


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34970/#review86846
-----------------------------------------------------------


On June 5, 2015, 7:56 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34970/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 7:56 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-2655
>     https://issues.apache.org/jira/browse/MESOS-2655
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Now the NoExecutorScheduler can take a custom command, as well as the 
> resources for the task and how many tasks to run.
> 
> This allows us to continue using it for an end-to-end test as part of make 
> check, but also allows it to be used against a cluster in a long-lived 
> fashion.
> 
> 
> Diffs
> -----
> 
>   src/examples/no_executor_framework.cpp 
> 1fb853d6e4a3deb3c36e6e661689697c8ebf898f 
>   src/tests/no_executor_framework_test.sh 
> d2d395595b778bc543e1baaa0fd415dc622b647f 
>   src/tests/script.cpp 515e3141e1d517da4cfc1421d5301d0a3bd6ad51 
> 
> Diff: https://reviews.apache.org/r/34970/diff/
> 
> 
> Testing
> -------
> 
> The existing no executor framework test picks this up.
> 
> Since we do not have an non-zero estimator yet, I modified the slave to send 
> revocable resources in order to manually test the revocable case.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to