-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35229/#review87224
-----------------------------------------------------------



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35229/#comment139547>

    TRAFFIC_CONTROL_STATISTICS is too generic, I don't see what it means from 
the name.



src/slave/containerizer/isolators/network/port_mapping.cpp
<https://reviews.apache.org/r/35229/#comment139546>

    Hmm, doesn't isSome() imply !isError()?


- Cong Wang


On June 8, 2015, 10:26 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35229/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 10:26 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2332
>     https://issues.apache.org/jira/browse/MESOS-2332
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Report per-container metrics for network bandwidth throttling to the slave.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 
> 4c719b186b519fad0c3869dbdae8b60c3a2c20cc 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f 
> 
> Diff: https://reviews.apache.org/r/35229/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to