----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35229/#review87485 -----------------------------------------------------------
src/slave/containerizer/isolators/network/port_mapping.hpp <https://reviews.apache.org/r/35229/#comment139820> Can you make those constexpr as well? Thanks! src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/35229/#comment139825> Hum, this is my fault. But given that more and more stats are being added, we probably should construct a ResourceStatistics message in 'execute()' and stringify it to JSON and print it. In the caller, we can parse it into ResourceStatistics and use MergeFrom to merge them? - Jie Yu On June 9, 2015, 9:56 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35229/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 9:56 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2836 > https://issues.apache.org/jira/browse/MESOS-2836 > > > Repository: mesos > > > Description > ------- > > Report per-container metrics for network bandwidth throttling to the slave. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp > 4c719b186b519fad0c3869dbdae8b60c3a2c20cc > src/slave/containerizer/isolators/network/port_mapping.cpp > d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f > > Diff: https://reviews.apache.org/r/35229/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Paul Brett > >
