----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/#review87331 -----------------------------------------------------------
src/tests/master_tests.cpp <https://reviews.apache.org/r/34361/#comment139669> Why bother with all this? Why not just have `"key1"`, `"value1"`, `"key2"`, `"value2"` inlined appropriately throughout these tests. Very straightforward to read. - Ben Mahler On June 8, 2015, 7:05 p.m., Colin Williams wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34361/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 7:05 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2637 > https://issues.apache.org/jira/browse/MESOS-2637 > > > Repository: mesos > > > Description > ------- > > converted hard-coded strings to consts > > > Diffs > ----- > > src/tests/hook_tests.cpp 3ffde6d > src/tests/master_tests.cpp ba3858f > src/tests/slave_tests.cpp acae497 > > Diff: https://reviews.apache.org/r/34361/diff/ > > > Testing > ------- > > > Thanks, > > Colin Williams > >
