reviews
Thread
Date
Earlier messages
Later messages
Messages by Date
2020/03/12
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Andrei Budnik
2020/03/12
Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.
Mesos Reviewbot
2020/03/12
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Qian Zhang
2020/03/12
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/03/12
Re: Review Request 72189: Updated nested mesos containerizer tests to support `shared_cgroups`.
Greg Mann
2020/03/12
Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.
Qian Zhang
2020/03/12
Re: Review Request 72189: Updated nested mesos containerizer tests to support `shared_cgroups`.
Qian Zhang
2020/03/12
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Qian Zhang
2020/03/12
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Qian Zhang
2020/03/12
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/03/11
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/03/11
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/03/11
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/03/11
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Mesos Reviewbot
2020/03/11
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/11
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/11
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/03/11
[GitHub] [mesos] eLvErDe opened a new pull request #352: Typo in master.md
GitBox
2020/03/11
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Mesos Reviewbot
2020/03/11
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/11
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Qian Zhang
2020/03/11
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Qian Zhang
2020/03/11
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
2020/03/11
Re: Review Request 71952: Set resource limits when updating executor container.
Greg Mann
2020/03/11
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Greg Mann
2020/03/11
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
2020/03/11
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Greg Mann
2020/03/11
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Greg Mann
2020/03/11
Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.
Greg Mann
2020/03/10
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Mesos Reviewbot
2020/03/10
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/10
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Qian Zhang
2020/03/10
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Mesos Reviewbot
2020/03/10
Review Request 72222: Added tests for agent validation of shared cgroups.
Greg Mann
2020/03/10
Review Request 72221: Added agent validation for shared cgroups.
Greg Mann
2020/03/10
Re: Review Request 72217: Added tests for resource limit and shared cgroup validation.
Andrei Budnik
2020/03/10
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
2020/03/10
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Greg Mann
2020/03/10
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Andrei Budnik
2020/03/10
Re: Review Request 72217: Added tests for resource limit and shared cgroup validation.
Mesos Reviewbot
2020/03/10
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/10
Re: Review Request 72217: Added tests for resource limit and shared cgroup validation.
Greg Mann
2020/03/10
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/10
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/10
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/10
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/10
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/10
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/10
Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/03/10
Re: Review Request 72215: Added resource limits to one overload of 'createTask()' helper.
Greg Mann
2020/03/10
Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/03/10
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/03/10
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/03/10
Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.
Qian Zhang
2020/03/10
Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.
Qian Zhang
2020/03/10
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Qian Zhang
2020/03/09
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Andrei Budnik
2020/03/09
Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.
Mesos Reviewbot
2020/03/09
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/03/09
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/03/09
Re: Review Request 72217: Added tests for resource limit and shared cgroup validation.
Mesos Reviewbot
2020/03/09
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/09
Review Request 72217: Added tests for resource limit and shared cgroup validation.
Greg Mann
2020/03/09
Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/09
Review Request 72215: Added resource limits to one overload of 'createTask()' helper.
Greg Mann
2020/03/09
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/03/09
Re: Review Request 71952: Set resource limits when updating executor container.
Qian Zhang
2020/03/09
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Qian Zhang
2020/03/09
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
2020/03/08
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
2020/03/08
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
2020/03/08
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
2020/03/08
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/03/08
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/03/07
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/07
Re: Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits.
Qian Zhang
2020/03/07
Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Qian Zhang
2020/03/07
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Qian Zhang
2020/03/07
Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Qian Zhang
2020/03/06
Re: Review Request 72208: Ensured that MasterAPITest.ReservationUpdate waits for changes on agent.
Mesos Reviewbot
2020/03/06
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/06
Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/03/06
Re: Review Request 72208: Ensured that MasterAPITest.ReservationUpdate waits for changes on agent.
Benjamin Mahler
2020/03/06
Review Request 72208: Ensured that MasterAPITest.ReservationUpdate waits for changes on agent.
Andrei Sekretenko
2020/03/06
Re: Review Request 72202: Fixed the broken PathTest.PathIteration on windows.
Andrei Sekretenko
2020/03/06
Re: Review Request 72201: Fixed the broken PathTest.Relative on Windows.
Andrei Sekretenko
2020/03/06
[GitHub] [mesos] wavesoft opened a new pull request #351: Ensure that long CNI labels are short enough
GitBox
2020/03/06
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Greg Mann
2020/03/06
Re: Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits.
Greg Mann
2020/03/06
Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CgroupsEnableCFS`.
Greg Mann
2020/03/06
Re: Review Request 72121: Moved cgroup path helpers to `paths.hpp`.
Qian Zhang
2020/03/06
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/06
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Qian Zhang
2020/03/06
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Qian Zhang
2020/03/06
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Qian Zhang
2020/03/06
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Greg Mann
2020/03/05
Re: Review Request 72161: Added patch for RapidJSON.
Qian Zhang
2020/03/05
Re: Review Request 72202: Fixed the broken PathTest.PathIteration on windows.
Mesos Reviewbot
2020/03/05
Review Request 72202: Fixed the broken PathTest.PathIteration on windows.
Benjamin Mahler
2020/03/05
Review Request 72201: Fixed the broken PathTest.Relative on Windows.
Benjamin Mahler
2020/03/05
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Greg Mann
2020/03/05
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Greg Mann
2020/03/05
Re: Review Request 71955: Add a new parameter `resourceLimits` to the `createTask` methods.
Greg Mann
2020/03/05
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Greg Mann
2020/03/05
Re: Review Request 71955: Add a new parameter `resourceLimits` to the `createTask` methods.
Greg Mann
2020/03/05
Re: Review Request 71952: Set resource limits when updating executor container.
Greg Mann
2020/03/05
Re: Review Request 71952: Set resource limits when updating executor container.
Greg Mann
2020/03/05
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Greg Mann
2020/03/05
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Greg Mann
2020/03/05
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Greg Mann
2020/03/05
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Greg Mann
2020/03/05
Re: Review Request 71885: Updated the `update()` method of subsystem to handle resource limits.
Greg Mann
2020/03/05
Re: Review Request 71884: Updated the `update()` method of isolator to handle resource limits.
Greg Mann
2020/03/04
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/04
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Qian Zhang
2020/03/04
Re: Review Request 72196: Removed stale MPI framework.
Benjamin Mahler
2020/03/04
Review Request 72196: Removed stale MPI framework.
Vinod Kone
2020/03/04
Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.
Mesos Reviewbot
2020/03/04
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/03/04
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
2020/03/04
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Greg Mann
2020/03/04
Re: Review Request 72161: Added patch for RapidJSON.
Greg Mann
2020/03/04
Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.
Mesos Reviewbot
2020/03/04
Re: Review Request 72161: Added patch for RapidJSON.
Greg Mann
2020/03/04
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
2020/03/04
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
2020/03/04
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/03/04
Review Request 72190: Added a test `LaunchNestedShareCgroups`.
Andrei Budnik
2020/03/04
Review Request 72189: Updated nested mesos containerizer tests to support `shared_cgroups`.
Andrei Budnik
2020/03/04
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
2020/03/04
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
2020/03/03
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/03
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
2020/03/03
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
2020/03/03
Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal.
Mesos Reviewbot
2020/03/03
Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal.
Benjamin Mahler
2020/03/03
Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal.
Andrei Sekretenko
2020/03/03
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Mesos Reviewbot
2020/03/03
Re: Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal.
Benjamin Mahler
2020/03/03
Re: Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows.
Mesos Reviewbot
2020/03/03
Review Request 72187: Fixed build on platforms not treating initializer_list<enum> as literal.
Andrei Sekretenko
2020/03/03
Re: Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows.
Andrei Sekretenko
2020/03/03
Re: Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows.
Benjamin Mahler
2020/03/03
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Qian Zhang
2020/03/03
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
2020/03/03
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
2020/03/03
Review Request 72185: Disabled RoleTest.RolesEndpointContainsConsumedQuota on Windows.
Andrei Sekretenko
2020/03/02
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
2020/03/02
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/02
Re: Review Request 71944: Set container process's OOM score adjust.
Greg Mann
2020/03/02
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
2020/03/02
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
2020/03/02
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Andrei Budnik
2020/03/02
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Greg Mann
2020/03/02
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/01
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
2020/03/01
Re: Review Request 72161: Added patch for RapidJSON.
Qian Zhang
2020/03/01
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
2020/03/01
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
2020/02/29
Re: Review Request 72161: Added patch for RapidJSON.
Qian Zhang
2020/02/28
Re: Review Request 72179: Got rid of passing Shared<> into `Subscribers::Subscriber::send(...)`.
Mesos Reviewbot
2020/02/28
Re: Review Request 72179: Got rid of passing Shared<> into `Subscribers::Subscriber::send(...)`.
Benjamin Mahler
2020/02/28
Re: Review Request 72178: Converted sending operator API events to synchronous authorization.
Benjamin Mahler
2020/02/28
Review Request 72179: Got rid of passing Shared<> into `Subscribers::Subscriber::send(...)`.
Andrei Sekretenko
2020/02/28
Review Request 72178: Converted sending operator API events to synchronous authorization.
Andrei Sekretenko
2020/02/28
Re: Review Request 72170: Added test for removal of ObjectApprovers of disconnected framework.
Mesos Reviewbot
2020/02/28
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Greg Mann
2020/02/28
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Greg Mann
2020/02/28
Re: Review Request 72170: Added test for removal of ObjectApprovers of disconnected framework.
Benjamin Mahler
2020/02/28
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
2020/02/28
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
2020/02/28
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
2020/02/28
Re: Review Request 72096: Store per-framework ObjectApprovers.
Andrei Sekretenko
2020/02/28
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
2020/02/28
Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.
Andrei Sekretenko
2020/02/28
Re: Review Request 71952: Set resource limits when updating executor container.
Greg Mann
2020/02/28
Re: Review Request 72170: Added test for removal of ObjectApprovers of disconnected framework.
Mesos Reviewbot
2020/02/28
Re: Review Request 72170: Added test for removal of ObjectApprovers of disconnected framework.
Andrei Sekretenko
2020/02/28
Review Request 72170: Added test for removal of ObjectApprovers of disconnected framework.
Andrei Sekretenko
2020/02/27
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
2020/02/27
Re: Review Request 72096: Store per-framework ObjectApprovers.
Benjamin Mahler
2020/02/27
Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.
Benjamin Mahler
2020/02/27
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
2020/02/27
Re: Review Request 72169: Made `overload()` work with callables passed by reference.
Benjamin Mahler
2020/02/27
Re: Review Request 72099: Removed code for tracking pending tasks.
Andrei Sekretenko
2020/02/27
Re: Review Request 72098: Converted ACCEPT to synchronous authorization.
Andrei Sekretenko
2020/02/27
Review Request 72169: Made `overload()` work with callables passed by reference.
Andrei Sekretenko
2020/02/27
Re: Review Request 72096: Store per-framework ObjectApprovers.
Andrei Sekretenko
2020/02/27
Re: Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
Andrei Sekretenko
2020/02/27
Re: Review Request 72089: Introduced `getApprover(...)` authorizer interface.
Andrei Sekretenko
2020/02/27
Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.
Andrei Sekretenko
2020/02/27
Re: Review Request 71858: Set resource limits when launching executor container.
Greg Mann
2020/02/27
Re: Review Request 72161: Added patch for RapidJSON.
Benjamin Bannier
2020/02/27
Re: Review Request 72161: Added patch for RapidJSON.
Greg Mann
2020/02/27
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Greg Mann
2020/02/27
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Greg Mann
2020/02/27
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Greg Mann
2020/02/26
Re: Review Request 72017: SSL Socket: Added downgrade support.
Greg Mann
2020/02/26
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/02/26
Re: Review Request 71952: Set resource limits when updating executor container.
Qian Zhang
Earlier messages
Later messages