-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35321/#review87498
-----------------------------------------------------------

Ship it!



src/slave/resource_estimators/fixed.cpp
<https://reviews.apache.org/r/35321/#comment139843>

    How about just s/resources/totalRevocable/ so that we don't need to clarify 
with this note? Then we can CHECK this in teh constructor (which it looks like 
we should do anyway?)



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35321/#comment139844>

    s/since the FixedResourcesEstimator is used//
    
    and maybe wrap to reduce jaggedness?
    
    ```
      // Launch a task that uses revocable resources and verify
      // that the total oversubscribed resources does not change.
    ```
    
    Maybe do a pass in the rest of this test too?



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35321/#comment139845>

    "revocable" with a c


- Ben Mahler


On June 10, 2015, 7:49 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35321/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 7:49 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2791
>     https://issues.apache.org/jira/browse/MESOS-2791
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented the fixed resource estimator.
> 
> 
> Diffs
> -----
> 
>   src/slave/resource_estimators/fixed.cpp 
> 3efa18d7e3c6ac62e67f75ea45a832f3f6349036 
>   src/tests/oversubscription_tests.cpp 
> 59cf07ef93460537ce1343793fd4a5d11d2ae242 
> 
> Diff: https://reviews.apache.org/r/35321/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to