> On June 11, 2015, 1:07 a.m., Ben Mahler wrote: > > src/tests/oversubscription_tests.cpp, lines 404-406 > > <https://reviews.apache.org/r/35321/diff/1/?file=982246#file982246line404> > > > > s/since the FixedResourcesEstimator is used// > > > > and maybe wrap to reduce jaggedness? > > > > ``` > > // Launch a task that uses revocable resources and verify > > // that the total oversubscribed resources does not change. > > ``` > > > > Maybe do a pass in the rest of this test too?
Removed the unneeded comments and adjust the wrapping. > On June 11, 2015, 1:07 a.m., Ben Mahler wrote: > > src/tests/oversubscription_tests.cpp, line 434 > > <https://reviews.apache.org/r/35321/diff/1/?file=982246#file982246line434> > > > > "revocable" with a c Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35321/#review87498 ----------------------------------------------------------- On June 10, 2015, 7:49 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35321/ > ----------------------------------------------------------- > > (Updated June 10, 2015, 7:49 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2791 > https://issues.apache.org/jira/browse/MESOS-2791 > > > Repository: mesos > > > Description > ------- > > Implemented the fixed resource estimator. > > > Diffs > ----- > > src/slave/resource_estimators/fixed.cpp > 3efa18d7e3c6ac62e67f75ea45a832f3f6349036 > src/tests/oversubscription_tests.cpp > 59cf07ef93460537ce1343793fd4a5d11d2ae242 > > Diff: https://reviews.apache.org/r/35321/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
