-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35157/#review87587
-----------------------------------------------------------



src/common/type_utils.cpp
<https://reviews.apache.org/r/35157/#comment139978>

    This doesn't match all fields in include/mesos/mesos.proto. Mind adding 
those?



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35157/#comment139981>

    s/that /that the/



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35157/#comment139982>

    s/from /from the/



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35157/#comment139983>

    Can you do this with an initializer list?
    
    ```
    vector<TaskInfo> tasks = {task};
    ```



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35157/#comment139984>

    Don't you want to ensure that the status update is actually TASK_RUNNING? :)



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35157/#comment139980>

    Let's not do these fly by changes :)



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35157/#comment139985>

    s/that /that the/



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35157/#comment139986>

    s/from /from the /



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35157/#comment139987>

    We need to update this to match the test above


- Niklas Nielsen


On June 8, 2015, 5:17 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35157/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 5:17 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Niklas Nielsen, Szymon Konefal, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for QoS Controller and ResourceEstimator fetching ResoruceUsage 
> from ResourceMonitor.
> 
> This is the unit test for https://reviews.apache.org/r/34980/ and 
> https://reviews.apache.org/r/35164/
> 
> 
> Diffs
> -----
> 
>   include/mesos/type_utils.hpp 52380c2461841026ee492797b4d8081f944f7b7b 
>   src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b 
>   src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 
>   src/tests/mesos.cpp dff45b0d3bf9ef53f19575ab3d90a0b223755d6a 
>   src/tests/oversubscription_tests.cpp 
> afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7 
> 
> Diff: https://reviews.apache.org/r/35157/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to