----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35157/#review87609 -----------------------------------------------------------
src/common/type_utils.cpp <https://reviews.apache.org/r/35157/#comment140005> Wow. This will become very hard to maintian (i.e., keep up-to-date) as we introduce more and more statistics (e.g., https://reviews.apache.org/r/34894). So could you please serialize the protobuf to string and test string equality since you want the strict equality here. src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/35157/#comment140006> Can you align FutureSatisfy and Return? Here and everywhere else. - Jie Yu On June 11, 2015, 6:55 p.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35157/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 6:55 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Niklas Nielsen, Szymon Konefal, > and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added tests for QoS Controller and ResourceEstimator fetching ResoruceUsage > from ResourceMonitor. > > This is the unit test for https://reviews.apache.org/r/34980/ and > https://reviews.apache.org/r/35164/ > > > Diffs > ----- > > include/mesos/type_utils.hpp 52380c2461841026ee492797b4d8081f944f7b7b > src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b > src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 > src/tests/mesos.cpp dff45b0d3bf9ef53f19575ab3d90a0b223755d6a > src/tests/oversubscription_tests.cpp > afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7 > > Diff: https://reviews.apache.org/r/35157/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bartek Plotka > >
