> On June 12, 2015, 3:49 p.m., Jie Yu wrote: > > src/slave/slave.cpp, lines 4203-4210 > > <https://reviews.apache.org/r/34720/diff/5/?file=983931#file983931line4203> > > > > Can you add a TODO here saying that we may want to check if > > containerId matches or not due to race (i.e., qos controller wants to kill > > container 1 of executor 1, but the executor you are checking here is for > > container 2 of executor 1). > > > > That means we need to add ContainerID in ResourceUsage/QoSCorrection as > > well
Added MESOS-2875 :) - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34720/#review87767 ----------------------------------------------------------- On June 16, 2015, 1:42 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34720/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 1:42 p.m.) > > > Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and > Vinod Kone. > > > Bugs: MESOS-2653 > https://issues.apache.org/jira/browse/MESOS-2653 > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > src/slave/flags.hpp 6c24e56d15881b0e3aeec3d4824842cf57121fc6 > src/slave/flags.cpp 93690cfa9dbf2658ce642829299f4adf08bb1062 > src/slave/slave.hpp dbed46d76cc7fbdd1a8d3ebcc2a1ff08b75da10f > src/slave/slave.cpp 361433063b5cb38d8326f8247cf4fc6f4a18e5c9 > src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 > src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 > > Diff: https://reviews.apache.org/r/34720/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
