> On June 16, 2015, 2:22 p.m., Jie Yu wrote: > > src/slave/slave.cpp, line 4210 > > <https://reviews.apache.org/r/34720/diff/6/?file=985948#file985948line4210> > > > > Shouldn't be 'executorId' here? Also, can you put single quotes for > > executorId since it's specifed by the user (i.e., might contain spaces).
Great point! Thanks! > On June 16, 2015, 2:22 p.m., Jie Yu wrote: > > src/slave/slave.cpp, line 4138 > > <https://reviews.apache.org/r/34720/diff/6/?file=985948#file985948line4138> > > > > I think we already have > > ``` > > using mesos::slave::QoSController; > > ``` > > > > So you can remove the namespace prefix. It probably will fit in one > > line. Added 'using mesos::slave::QoSCorrection;' - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34720/#review88124 ----------------------------------------------------------- On June 16, 2015, 4:47 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34720/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 4:47 p.m.) > > > Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and > Vinod Kone. > > > Bugs: MESOS-2653 > https://issues.apache.org/jira/browse/MESOS-2653 > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > src/slave/flags.hpp 6c24e56d15881b0e3aeec3d4824842cf57121fc6 > src/slave/flags.cpp 93690cfa9dbf2658ce642829299f4adf08bb1062 > src/slave/slave.hpp dbed46d76cc7fbdd1a8d3ebcc2a1ff08b75da10f > src/slave/slave.cpp 361433063b5cb38d8326f8247cf4fc6f4a18e5c9 > src/tests/mesos.hpp ecdf9109d2e46e8730754eeeb4978863679d56e7 > src/tests/mesos.cpp 509f9f205fdb1fa094e313b6f0da53000ffecbb3 > src/tests/oversubscription_tests.cpp > 3481ad2eef43c3860642970b4c96494997de8552 > > Diff: https://reviews.apache.org/r/34720/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
