> On June 2, 2015, 2:45 p.m., Timothy Chen wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 95 > > <https://reviews.apache.org/r/34135/diff/1/?file=957256#file957256line95> > > > > actually I'm wrong, I was reading the old style guide. The newest style > > guide we do put a space, ignore my earler comment.
? Doesn't https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md say: "Don't put a space between the capture list and the parameter list"? - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review86293 ----------------------------------------------------------- On May 12, 2015, 5:47 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34135/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 5:47 p.m.) > > > Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Moved code from Mesos Containerizer to filesystem isolators > - filesystem/posix (symlinks, doesn't support container rootfs) > - filesystem/linux (bind mounts, does support container rootfs) > > The filesystem/posix isolator will be automatically included if no > filesystem/ isolator is specified. > > > Diffs > ----- > > src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 > src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/posix.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/posix.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.cpp > b9e22e3c70bed0c29e2ca8632411789d33f779a8 > src/slave/containerizer/mesos/containerizer.cpp > b644b9c74bc23cf78c0a53284544be6cdaef2f8a > > Diff: https://reviews.apache.org/r/34135/diff/ > > > Testing > ------- > > existing persistent volumes tests. > > > Thanks, > > Ian Downes > >
