reviews
Thread
Date
Earlier messages
Later messages
Messages by Date
2020/04/02
[GitHub] [mesos] cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.
GitBox
2020/04/02
[GitHub] [mesos] abudnik commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.
GitBox
2020/04/01
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Qian Zhang
2020/04/01
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Mesos Reviewbot
2020/04/01
Re: Review Request 72305: Sent appropriate task status reason when task over memory request.
Greg Mann
2020/04/01
Review Request 72305: Sent appropriate task status reason when task over memory request.
Greg Mann
2020/04/01
Re: Review Request 72297: Added agent-side validation for resource limits.
Mesos Reviewbot
2020/04/01
Re: Review Request 72297: Added agent-side validation for resource limits.
Qian Zhang
2020/04/01
Re: Review Request 72304: Moved documentation into os/shell.hpp interface.
Mesos Reviewbot
2020/04/01
Review Request 72297: Added agent-side validation for resource limits.
Greg Mann
2020/04/01
Review Request 72304: Moved documentation into os/shell.hpp interface.
Benjamin Mahler
2020/04/01
Review Request 72303: Moved documentation into os/exec.hpp interface.
Benjamin Mahler
2020/04/01
[GitHub] [mesos] cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.
GitBox
2020/04/01
[GitHub] [mesos] abudnik commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.
GitBox
2020/04/01
[GitHub] [mesos] cf-natali opened a new pull request #355: Handle EBUSY when destroying a cgroup.
GitBox
2020/04/01
Re: Review Request 72296: Added missing await in a cgroups isolator test.
Mesos Reviewbot
2020/03/31
Review Request 72296: Added missing await in a cgroups isolator test.
Greg Mann
2020/03/31
Re: Review Request 72269: Added resource limits to the web UI.
Qian Zhang
2020/03/31
Re: Review Request 72269: Added resource limits to the web UI.
Mesos Reviewbot
2020/03/31
Re: Review Request 72269: Added resource limits to the web UI.
Greg Mann
2020/03/31
Re: Review Request 72269: Added resource limits to the web UI.
Greg Mann
2020/03/30
Re: Review Request 72269: Added resource limits to the web UI.
Mesos Reviewbot
2020/03/30
Re: Review Request 72269: Added resource limits to the web UI.
Greg Mann
2020/03/30
Re: Review Request 72269: Added resource limits to the web UI.
Greg Mann
2020/03/30
Re: Review Request 72269: Added resource limits to the web UI.
Qian Zhang
2020/03/30
Re: Review Request 72286: Updated mesos for os/exec.hpp addition to stout.
Mesos Reviewbot
2020/03/30
Re: Review Request 72269: Added resource limits to the web UI.
Mesos Reviewbot
2020/03/30
Review Request 72285: Updated libprocess for exec.hpp addition to stout.
Benjamin Mahler
2020/03/30
Review Request 72273: Split out exec.hpp from shell.hpp in stout.
Benjamin Mahler
2020/03/30
Review Request 72286: Updated mesos for os/exec.hpp addition to stout.
Benjamin Mahler
2020/03/30
Re: Review Request 72269: Added resource limits to the web UI.
Greg Mann
2020/03/30
Re: Review Request 72269: Added resource limits to the web UI.
Andrei Sekretenko
2020/03/27
Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call.
Benjamin Mahler
2020/03/27
Re: Review Request 72275: Added Dong Zhu to contributors list.
Benjamin Mahler
2020/03/26
Re: Review Request 72275: Added Dong Zhu to contributors list.
Mesos Reviewbot
2020/03/26
Re: Review Request 72275: Added Dong Zhu to contributors list.
Dong Zhu
2020/03/26
Review Request 72275: Added Dong Zhu to contributors list.
Dong Zhu
2020/03/25
[GitHub] [mesos] bmahler closed pull request #353: Hook manager mutex and global variable enhancement.
GitBox
2020/03/25
Re: Review Request 72269: Added resource limits to the web UI.
Mesos Reviewbot
2020/03/25
Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call.
Andrei Sekretenko
2020/03/25
Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call.
Benjamin Mahler
2020/03/25
Review Request 72269: Added resource limits to the web UI.
Greg Mann
2020/03/25
Re: Review Request 72267: Added docs for UPDATE_FRAMEWORK call.
Mesos Reviewbot
2020/03/25
Review Request 72267: Added docs for UPDATE_FRAMEWORK call.
Andrei Sekretenko
2020/03/25
[GitHub] [mesos] asfgit closed pull request #354: Avoid error on mesos logs upon docker image fetch
GitBox
2020/03/24
[GitHub] [mesos] bluezd commented on a change in pull request #353: Hook manager mutex and global variable enhancement.
GitBox
2020/03/24
[GitHub] [mesos] bluezd commented on a change in pull request #353: Hook manager mutex and global variable enhancement.
GitBox
2020/03/24
[GitHub] [mesos] bluezd commented on a change in pull request #353: hook manager mutex and global variable enhancement
GitBox
2020/03/24
Re: Review Request 72262: Added resource limits to v0 endpoint results.
Qian Zhang
2020/03/24
Re: Review Request 72262: Added resource limits to v0 endpoint results.
Mesos Reviewbot
2020/03/24
Re: Review Request 72262: Added resource limits to v0 endpoint results.
Greg Mann
2020/03/24
[GitHub] [mesos] bmahler commented on issue #354: Avoid error on mesos logs upon docker image fetch
GitBox
2020/03/24
[GitHub] [mesos] bmahler commented on a change in pull request #353: hook manager mutex and global variable enhancement
GitBox
2020/03/24
[GitHub] [mesos] bmahler commented on a change in pull request #353: hook manager mutex and global variable enhancement
GitBox
2020/03/24
[GitHub] [mesos] bmahler commented on issue #353: hook manager mutex and global variable enhancement
GitBox
2020/03/24
Re: Review Request 72263: Moved containerizer utils in CMakeLists.
Greg Mann
2020/03/24
Re: Review Request 72263: Moved containerizer utils in CMakeLists.
Mesos Reviewbot
2020/03/24
Review Request 72263: Moved containerizer utils in CMakeLists.
Qian Zhang
2020/03/24
Re: Review Request 72262: Added resource limits to v0 endpoint results.
Qian Zhang
2020/03/23
Re: Review Request 72262: Added resource limits to v0 endpoint results.
Mesos Reviewbot
2020/03/23
Review Request 72262: Added resource limits to v0 endpoint results.
Greg Mann
2020/03/23
[GitHub] [mesos] bluezd commented on issue #353: hook manager mutex and global variable enhancement
GitBox
2020/03/23
[GitHub] [mesos] bluezd commented on a change in pull request #353: hook manager mutex and global variable enhancement
GitBox
2020/03/23
[GitHub] [mesos] bluezd commented on a change in pull request #353: hook manager mutex and global variable enhancement
GitBox
2020/03/23
[GitHub] [mesos] bluezd commented on issue #353: hook manager mutex and global variable enhancement
GitBox
2020/03/23
Re: Review Request 72239: Added stack trace logging to program crashes on windows.
Andrei Sekretenko
2020/03/23
[GitHub] [mesos] bmahler commented on a change in pull request #353: hook manager mutex and global variable enhancement
GitBox
2020/03/23
[GitHub] [mesos] bmahler commented on a change in pull request #353: hook manager mutex and global variable enhancement
GitBox
2020/03/23
[GitHub] [mesos] kamaradclimber opened a new pull request #354: Avoid error on mesos logs upon docker image fetch
GitBox
2020/03/20
Re: Review Request 72239: Added stack trace logging to program crashes on windows.
Mesos Reviewbot
2020/03/20
Re: Review Request 72239: Added stack trace logging to program crashes on windows.
Benjamin Mahler
2020/03/20
Re: Review Request 72239: Added stack trace logging to program crashes on windows.
Benjamin Mahler
2020/03/20
Re: Review Request 72239: Added stack trace logging to program crashes on windows.
Benjamin Mahler
2020/03/20
Re: Review Request 72250: Updated the comment for the 'share_cgroups' field.
Mesos Reviewbot
2020/03/20
Re: Review Request 72217: Added tests for master validation of limits and shared cgroups.
Greg Mann
2020/03/20
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Greg Mann
2020/03/20
Re: Review Request 72250: Updated the comment for the 'share_cgroups' field.
Greg Mann
2020/03/20
Re: Review Request 72221: Added agent validation for shared cgroups.
Greg Mann
2020/03/20
Re: Review Request 72239: Added stack trace logging to program crashes on windows.
Andrei Sekretenko
2020/03/20
Re: Review Request 72250: Updated the comment for the 'share_cgroups' field.
Mesos Reviewbot
2020/03/20
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Qian Zhang
2020/03/20
Re: Review Request 72250: Updated the comment for the 'share_cgroups' field.
Qian Zhang
2020/03/20
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Qian Zhang
2020/03/20
Re: Review Request 72221: Added agent validation for shared cgroups.
Qian Zhang
2020/03/19
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72250: Updated the comment for the 'share_cgroups' field.
Mesos Reviewbot
2020/03/19
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72217: Added tests for master validation of limits and shared cgroups.
Qian Zhang
2020/03/19
Re: Review Request 72250: Updated the comment for the 'share_cgroups' field.
Mesos Reviewbot
2020/03/19
Re: Review Request 72217: Added tests for master validation of limits and shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72161: Added patch for RapidJSON.
Qian Zhang
2020/03/19
Re: Review Request 72221: Added agent validation for shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72161: Added patch for RapidJSON.
Greg Mann
2020/03/19
Re: Review Request 72250: Updated the comment for the 'share_cgroups' field.
Mesos Reviewbot
2020/03/19
Re: Review Request 72221: Added agent validation for shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72250: Updated the comment for the 'share_cgroups' field.
Mesos Reviewbot
2020/03/19
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Qian Zhang
2020/03/19
Re: Review Request 72250: Updated the comment for the 'share_cgroups' field.
Mesos Reviewbot
2020/03/19
Re: Review Request 72221: Added agent validation for shared cgroups.
Qian Zhang
2020/03/19
Review Request 72250: Updated the comment for the 'share_cgroups' field.
Greg Mann
2020/03/19
[GitHub] [mesos] bluezd opened a new pull request #353: hook manager mutex and global variable enhancement
GitBox
2020/03/19
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/19
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Qian Zhang
2020/03/18
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Qian Zhang
2020/03/18
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Mesos Reviewbot
2020/03/18
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Greg Mann
2020/03/18
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Greg Mann
2020/03/18
Re: Review Request 71944: Set container process's OOM score adjust.
Greg Mann
2020/03/18
Re: Review Request 72221: Added agent validation for shared cgroups.
Greg Mann
2020/03/18
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Greg Mann
2020/03/18
Re: Review Request 72221: Added agent validation for shared cgroups.
Greg Mann
2020/03/18
Re: Review Request 72217: Added tests for master validation of limits and shared cgroups.
Greg Mann
2020/03/18
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/18
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Greg Mann
2020/03/18
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/18
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Qian Zhang
2020/03/17
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/17
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Greg Mann
2020/03/17
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Greg Mann
2020/03/17
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Greg Mann
2020/03/17
Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Greg Mann
2020/03/17
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Greg Mann
2020/03/17
Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Greg Mann
2020/03/17
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Qian Zhang
2020/03/17
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/17
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Mesos Reviewbot
2020/03/17
Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Qian Zhang
2020/03/17
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Qian Zhang
2020/03/17
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Qian Zhang
2020/03/17
Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Qian Zhang
2020/03/16
Re: Review Request 72239: Added stack trace logging to program crashes on windows.
Mesos Reviewbot
2020/03/16
Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Qian Zhang
2020/03/16
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Qian Zhang
2020/03/16
Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Qian Zhang
2020/03/16
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Qian Zhang
2020/03/16
Re: Review Request 72239: Added stack trace logging to program crashes on windows.
Mesos Reviewbot
2020/03/16
Review Request 72239: Added stack trace logging to program crashes on windows.
Benjamin Mahler
2020/03/16
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/16
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Mesos Reviewbot
2020/03/16
Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/03/16
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
2020/03/16
Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Qian Zhang
2020/03/16
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Qian Zhang
2020/03/16
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/03/16
Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Qian Zhang
2020/03/16
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Qian Zhang
2020/03/16
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Greg Mann
2020/03/16
Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Greg Mann
2020/03/16
Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Greg Mann
2020/03/16
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Greg Mann
2020/03/16
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/16
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Greg Mann
2020/03/16
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Mesos Reviewbot
2020/03/16
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Qian Zhang
2020/03/16
Re: Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits.
Qian Zhang
2020/03/16
Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Qian Zhang
2020/03/16
Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/03/16
Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.
Qian Zhang
2020/03/16
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Qian Zhang
2020/03/16
Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Qian Zhang
2020/03/16
Re: Review Request 71955: Added a new parameter `resourceLimits` to the `createTask` methods.
Qian Zhang
2020/03/16
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/03/16
Re: Review Request 71952: Set resource limits when updating executor container.
Qian Zhang
2020/03/16
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.
Qian Zhang
2020/03/16
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
2020/03/16
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Qian Zhang
2020/03/16
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
2020/03/16
Re: Review Request 71943: Set container's `memory.limit_in_bytes` to its memory limit.
Qian Zhang
2020/03/16
Re: Review Request 71885: Updated the `update()` method of subsystem to handle resource limits.
Qian Zhang
2020/03/16
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Qian Zhang
2020/03/16
Re: Review Request 71884: Updated the `update()` method of isolator to handle resource limits.
Qian Zhang
2020/03/16
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
2020/03/16
Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
2020/03/16
Re: Review Request 72161: Added patch for RapidJSON.
Qian Zhang
2020/03/16
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/16
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
2020/03/16
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Mesos Reviewbot
2020/03/16
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Qian Zhang
2020/03/16
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
2020/03/16
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
2020/03/15
Re: Review Request 72221: Added agent validation for shared cgroups.
Qian Zhang
2020/03/15
Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Qian Zhang
2020/03/13
[GitHub] [mesos] bmahler closed pull request #352: Typo in master.md
GitBox
2020/03/13
[GitHub] [mesos] bmahler commented on issue #352: Typo in master.md
GitBox
2020/03/13
Re: Review Request 72221: Added agent validation for shared cgroups.
Andrei Budnik
2020/03/13
Re: Review Request 72233: Fixed undefined behavior in ActionObject::reserve.
Andrei Sekretenko
2020/03/12
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/03/12
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/03/12
Re: Review Request 72233: Fixed undefined behavior in ActionObject::reserve.
Mesos Reviewbot
2020/03/12
Review Request 72233: Fixed undefined behavior in ActionObject::reserve.
Benjamin Mahler
2020/03/12
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Mesos Reviewbot
2020/03/12
Re: Review Request 72222: Added tests for agent validation of shared cgroups.
Greg Mann
2020/03/12
Re: Review Request 72221: Added agent validation for shared cgroups.
Greg Mann
Earlier messages
Later messages