> On June 16, 2015, 10:33 p.m., Jie Yu wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 713 > > <https://reviews.apache.org/r/35536/diff/1/?file=985924#file985924line713> > > > > I don't think you need to set this. > > Paul Brett wrote: > It is a required field. Without it, the conversion to JSON does not > generate a timestamp and hence the conversion back fails.
Then, we should use a dummy value here and call clear_timestamp() in the host namespace. Otherwise, it will overwrite the final timestamp set in the containerizer. I'll fix this for you. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35536/#review88147 ----------------------------------------------------------- On June 16, 2015, 11:44 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35536/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 11:44 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2874 > https://issues.apache.org/jira/browse/MESOS-2874 > > > Repository: mesos > > > Description > ------- > > Replace adhoc JSON conversion functions for ResourceStatistics with a > protocol buffer to JSON converter. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp > 4c719b186b519fad0c3869dbdae8b60c3a2c20cc > src/slave/containerizer/isolators/network/port_mapping.cpp > e55e7b62bc29125458f9c0fb5477057ecc5a90df > src/tests/port_mapping_tests.cpp f8372df74cd71df37de4a2438069ef0ea8878512 > > Diff: https://reviews.apache.org/r/35536/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Paul Brett > >
