-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571/#review88359
-----------------------------------------------------------

Ship it!


This looks great Marco. Let's get this committed folks! Then please follow up 
with a test as asked by some of your reviewers.


src/master/constants.hpp (line 102)
<https://reviews.apache.org/r/35571/#comment140844>

    Is there a way to capture deprecated with Doxygen?



src/master/detector.cpp (line 446)
<https://reviews.apache.org/r/35571/#comment140843>

    Misspelled ZooKeeper. ;-)



src/master/detector.cpp (lines 468 - 469)
<https://reviews.apache.org/r/35571/#comment140841>

    You should always know this is an error because you're in the 'else' 
branch, so you can just do:
    
    LOG(WARNING) << "Could not parse the JSON from Zookeeper into a valid "
                 << "MasterInfo protobuf '" << data.get().get() << "': "
                 << masterInfo.error();



src/master/detector.cpp (lines 476 - 477)
<https://reviews.apache.org/r/35571/#comment140842>

    Same here as above, you can just do:
    
    "Failed to parse JSON into a valid MasterInfo protocol buffer: " +
    masterInfo.error());


- Benjamin Hindman


On June 18, 2015, 2:27 a.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35571/
> -----------------------------------------------------------
> 
> (Updated June 18, 2015, 2:27 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2340
>     https://issues.apache.org/jira/browse/MESOS-2340
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Jira: MESOS-2340
> 
> The Leader detector will now also try to
> read nodes with label master::MASTER_INFO_JSON_LABEL
> and parse the contents as JSON, converting the data
> to a mesos::MasterInfo protobuf.
> 
> The ability to support binary data in PB format is
> still supported and the master::Contender will continue
> to serialize the binary data, so as to be compatible with
> 0.22 Mesos Masters.
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp 57cf8fbeff203847b5b5442f6c78ca9c09bcc66d 
>   src/master/constants.cpp 8c7174a9940bd332832bf85d81ab13cf11836dd0 
>   src/master/detector.cpp 5700711771480f4e5da88e60657618c955f10048 
> 
> Diff: https://reviews.apache.org/r/35571/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Reply via email to