----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35571/#review88423 -----------------------------------------------------------
Thanks Marco, want to see this polished off properly before a ship it. :) src/master/detector.cpp (lines 450 - 451) <https://reviews.apache.org/r/35571/#comment140937> This fits on one line. src/master/detector.cpp (line 461) <https://reviews.apache.org/r/35571/#comment140938> s/masterInfo/info/ to be consistent with the above naming src/master/detector.cpp (lines 464 - 478) <https://reviews.apache.org/r/35571/#comment140940> Can you keep the logic consistent by handling the error first? ``` if (info.isError()) { ... return; } leader = info.get(); ``` src/master/detector.cpp (lines 467 - 469) <https://reviews.apache.org/r/35571/#comment140939> Ditto from before, please remove this habit :) The caller will log the promise failure, as done in the above cases. src/master/detector.cpp (lines 471 - 472) <https://reviews.apache.org/r/35571/#comment140941> Comment not adding value IMO, can you remove it? - Ben Mahler On June 18, 2015, 3:31 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35571/ > ----------------------------------------------------------- > > (Updated June 18, 2015, 3:31 p.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-2340 > https://issues.apache.org/jira/browse/MESOS-2340 > > > Repository: mesos > > > Description > ------- > > Jira: MESOS-2340 > > The Leader detector will now also try to > read nodes with label master::MASTER_INFO_JSON_LABEL > and parse the contents as JSON, converting the data > to a mesos::MasterInfo protobuf. > > The ability to support binary data in PB format is > still supported and the master::Contender will continue > to serialize the binary data, so as to be compatible with > 0.22 Mesos Masters. > > > Diffs > ----- > > src/master/constants.hpp 57cf8fbeff203847b5b5442f6c78ca9c09bcc66d > src/master/constants.cpp 8c7174a9940bd332832bf85d81ab13cf11836dd0 > src/master/detector.cpp 5700711771480f4e5da88e60657618c955f10048 > > Diff: https://reviews.apache.org/r/35571/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >
