> On June 21, 2015, 5:56 p.m., Michael Park wrote: > > src/common/http.cpp, line 88 > > <https://reviews.apache.org/r/35717/diff/1/?file=989232#file989232line88> > > > > `s/key/role/`
I think use key may be more general. Because this method not only could be used to generate "role -> resources" json, also could be used to generate "principal -> resources" json. Or other any keys. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/#review88703 ----------------------------------------------------------- On June 21, 2015, 6:04 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35717/ > ----------------------------------------------------------- > > (Updated June 21, 2015, 6:04 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-692 > https://issues.apache.org/jira/browse/MESOS-692 > > > Repository: mesos > > > Description > ------- > > Add reservations support to master's state.json > > > Diffs > ----- > > src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 > src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c > src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e > src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf > > Diff: https://reviews.apache.org/r/35717/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
