> On June 24, 2015, 3:24 a.m., Adam B wrote: > > src/common/http.cpp, line 84 > > <https://reviews.apache.org/r/35717/diff/4/?file=989671#file989671line84> > > > > I wonder if you could templatize this to work for modeling any > > hashmap<string, T>, where T is an already modeled type.
I'm not sure what other hashmaps we'd model in JSON. We can always templatize it when we run across the next hashmap type. Dropping this issue so I can commit the patch as is. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/#review89146 ----------------------------------------------------------- On June 22, 2015, 4:37 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35717/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 4:37 a.m.) > > > Review request for mesos, Adam B and Michael Park. > > > Bugs: MESOS-692 > https://issues.apache.org/jira/browse/MESOS-692 > > > Repository: mesos > > > Description > ------- > > Add reservations support to master's state.json > > > Diffs > ----- > > src/common/http.hpp 6f100f74e4d3c10a087b4af11fc6864293f0f6f8 > src/common/http.cpp 4c8102e3cd75e9284dac3d535545370ca37f502c > src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e > src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf > > Diff: https://reviews.apache.org/r/35717/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
