-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
-----------------------------------------------------------
(Updated June 22, 2015, 2:35 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris
Van Remoortere, and Vinod Kone.
Changes
-------
Added tests for the error cases.
Bugs: MESOS-2600
https://issues.apache.org/jira/browse/MESOS-2600
Repository: mesos
Description
-------
This is still a work in progress, but I'm sharing to gather some feedback
around:
(1) I've added `updateAvailable` to the allocator API. Is this necessary or is
there maybe a better way?
(2) To determine the amount of available resources, I used: `available = total
- (offered + used)`.
Is this still correct with oversubscription in the picture?
(3) I'm creating an `Offer.Operation` to perform the necessary updates in the
allocator and such.
Feels weird to use an "offer" operation when there's not an actual offer.
Is this fine for now?
Diffs (updated)
-----
include/mesos/master/allocator.hpp 92de1af414321281b00eaa6f129e5e3e2c849448
src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573
src/master/allocator/mesos/allocator.hpp
6cfa04650d91a80211cfbc0809236f9438926c78
src/master/allocator/mesos/hierarchical.hpp
646ee8c1c0fb824e1d17150b4e96e6281c65358f
src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e
src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d
src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160
src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051
src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3
src/tests/reserve_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/35702/diff/
Testing
-------
Added `src/tests/reserve_tests.cpp` which still need to be fleshed out for
error cases (missing parameters, unauthorized client, etc).
Thanks,
Michael Park
