----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35738/#review88844 -----------------------------------------------------------
Patch looks great! Reviews applied: [35738] All tests passed. - Mesos ReviewBot On June 22, 2015, 7:26 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35738/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 7:26 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-2904 > https://issues.apache.org/jira/browse/MESOS-2904 > > > Repository: mesos > > > Description > ------- > > Add slave metric to count container launch failures. > > > Diffs > ----- > > src/slave/metrics.hpp 780c438b07993253c75275fd3956f1631b3c0d73 > src/slave/metrics.cpp 87289f2da83f211e1244d425c1d003e2ae79b507 > src/slave/slave.cpp 946e372252e6188b28f94452f1479824a7e201cd > src/tests/metrics_tests.cpp 6896727a23c1d6b0e2055ee661042a0a66b09067 > src/tests/slave_tests.cpp 50301983c674ef50a64294816db9587bf065aa9e > > Diff: https://reviews.apache.org/r/35738/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Paul Brett > >