-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35738/#review89014
-----------------------------------------------------------



src/slave/metrics.hpp (line 68)
<https://reviews.apache.org/r/35738/#comment141611>

    s/launch_failures/container_launch_errors/



src/slave/metrics.cpp (line 89)
<https://reviews.apache.org/r/35738/#comment141612>

    slave/container_launch_errors



src/slave/slave.cpp (line 3200)
<https://reviews.apache.org/r/35738/#comment141613>

    I think we prefer ++metrics.container_launch_errors;



src/slave/slave.cpp (line 3212)
<https://reviews.apache.org/r/35738/#comment141614>

    Ditto here.



src/tests/slave_tests.cpp (line 939)
<https://reviews.apache.org/r/35738/#comment141624>

    I don't think you need an executor. Simply use the TestContainerizer 
without the executor.



src/tests/slave_tests.cpp (line 942)
<https://reviews.apache.org/r/35738/#comment141626>

    Can you instead capture the destroy as well so that you don't need to add 
this flag?
    
    Another option is to relax the CHECK in TestContainerizer. I don't think 
that CHECK is necessary.



src/tests/slave_tests.cpp (line 953)
<https://reviews.apache.org/r/35738/#comment141619>

    Kill this line.



src/tests/slave_tests.cpp (line 962)
<https://reviews.apache.org/r/35738/#comment141620>

    const Offer



src/tests/slave_tests.cpp (line 969)
<https://reviews.apache.org/r/35738/#comment141628>

    s/Launch failed/Injected failure/



src/tests/slave_tests.cpp (line 970)
<https://reviews.apache.org/r/35738/#comment141629>

    Why do you need this?



src/tests/slave_tests.cpp (lines 972 - 979)
<https://reviews.apache.org/r/35738/#comment141621>

    ```
    TaskInfo task = createTask(...);
    ...
    driver.launchTasks(offer.id(), {task});
    ```



src/tests/slave_tests.cpp (lines 981 - 982)
<https://reviews.apache.org/r/35738/#comment141627>

    You don't need this if you use the TestContainerizer with no executor.



src/tests/slave_tests.cpp (line 986)
<https://reviews.apache.org/r/35738/#comment141618>

    Please fix the typo.


- Jie Yu


On June 23, 2015, 12:42 a.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35738/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 12:42 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2904
>     https://issues.apache.org/jira/browse/MESOS-2904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add slave metric to count container launch failures.
> 
> 
> Diffs
> -----
> 
>   src/slave/metrics.hpp 780c438b07993253c75275fd3956f1631b3c0d73 
>   src/slave/metrics.cpp 87289f2da83f211e1244d425c1d003e2ae79b507 
>   src/slave/slave.cpp 946e372252e6188b28f94452f1479824a7e201cd 
>   src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711 
>   src/tests/containerizer.cpp 80b910515694c81cf5b1eace1d79a5178cf35426 
>   src/tests/metrics_tests.cpp 6896727a23c1d6b0e2055ee661042a0a66b09067 
>   src/tests/slave_tests.cpp 50301983c674ef50a64294816db9587bf065aa9e 
> 
> Diff: https://reviews.apache.org/r/35738/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to