----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34256/#review88998 -----------------------------------------------------------
Ship it! much cleaner. thank you! 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 41) <https://reviews.apache.org/r/34256/#comment141587> extraneous "/" in slashes. 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 45) <https://reviews.apache.org/r/34256/#comment141588> ditto. 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 73) <https://reviews.apache.org/r/34256/#comment141589> ditto. 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 76) <https://reviews.apache.org/r/34256/#comment141590> don't you want to do the same short circuit as in basename() for path containing only slashes? 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line 81) <https://reviews.apache.org/r/34256/#comment141591> s/non trailing// ? - Vinod Kone On June 23, 2015, 8:26 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34256/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 8:26 a.m.) > > > Review request for mesos and Cody Maloney. > > > Bugs: MESOS-1303 > https://issues.apache.org/jira/browse/MESOS-1303 > > > Repository: mesos-incubating > > > Description > ------- > > Introducing Path::dirname() and Path::basename() as a thread safe replacement > of the respective system functions. Also contains new tests covering corner > cases. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > 59595c9d0372cb7fc8ec5acbab91ee298b673167 > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp > 7dd266421377e3f531c15cdf17377141f26c2715 > > Diff: https://reviews.apache.org/r/34256/diff/ > > > Testing > ------- > > make check (including new tests). > > Result comparison to match ::dirname and ::basename on interesting cases. > > > Thanks, > > Till Toenshoff > >
