> On June 23, 2015, 3:01 p.m., Jie Yu wrote: > > src/slave/containerizer/linux_launcher.hpp, line 33 > > <https://reviews.apache.org/r/35586/diff/5/?file=990176#file990176line33> > > > > I think fo LinuxLauncher, we can just use 'int namespaces' (no need to > > use Option).
Using a plain 'int' makes the call sites a bit harder in isolator_tests and port-mapping tests where we would then have to check whether the corresponding isolator returns a None() or not before calling into `LinuxLauncher::create`. If there is a strong preference, I can change it, otherwise, let's leave it as is. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/#review89025 ----------------------------------------------------------- On June 23, 2015, 3:05 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35586/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 3:05 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Niklas Nielsen. > > > Bugs: MESOS-2884 > https://issues.apache.org/jira/browse/MESOS-2884 > > > Repository: mesos > > > Description > ------- > > MesosContainerizer looks up the list of required namespaces by calling > Isolator::namespaces() for all enabled isolators and passes on this > value to LinuxLauncher. > > > Diffs > ----- > > src/slave/containerizer/linux_launcher.hpp > ec08e24b9ba525893d218636ebddea480e641bbf > src/slave/containerizer/linux_launcher.cpp > 8eae258d81229e19f8c587f5e023b1df7deed025 > src/slave/containerizer/mesos/containerizer.cpp > 8c102fb7d1f79ee768cb06de3a976ea12f958712 > src/tests/isolator_tests.cpp c635a4d5c78d71ca5474993eba57d1f81be9cbf1 > src/tests/port_mapping_tests.cpp 6caab134fdbf3894f9fae801daf9491a13888c7d > > Diff: https://reviews.apache.org/r/35586/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
