-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815/#review89297
-----------------------------------------------------------

Ship it!


Nice test!


src/tests/master_contender_detector_tests.cpp (line 848)
<https://reviews.apache.org/r/35815/#comment141886>

    s/know/known/



src/tests/master_contender_detector_tests.cpp (lines 856 - 858)
<https://reviews.apache.org/r/35815/#comment141887>

    We generally avoid putting LOG messages in tests. I would recommend to kill 
this.



src/tests/master_contender_detector_tests.cpp (line 864)
<https://reviews.apache.org/r/35815/#comment141888>

    s/writing/write/



src/tests/master_contender_detector_tests.cpp (line 877)
<https://reviews.apache.org/r/35815/#comment141889>

    s/EXPECT/ASSERT/
    
    as this is the last expectation in the test.


- Vinod Kone


On June 24, 2015, 6:01 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35815/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 6:01 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2898
>     https://issues.apache.org/jira/browse/MESOS-2898
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As of Mesos 0.24, we will support JSON format
> for the MasterInfo information written out to
> ZooKeeper for the Leader election process.
> 
> This tests that the JSON can be correctly parsed
> and the correct MasterInfo information retrieved.
> 
> Jira: MESOS-2898
> 
> 
> Diffs
> -----
> 
>   src/tests/master_contender_detector_tests.cpp 
> 1b30eeb51520da7a5834768ac88a88a8a84fd976 
> 
> Diff: https://reviews.apache.org/r/35815/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Reply via email to