> On June 25, 2015, 12:38 a.m., Vinod Kone wrote:
> > src/tests/master_contender_detector_tests.cpp, line 877
> > <https://reviews.apache.org/r/35815/diff/3/?file=991386#file991386line877>
> >
> >     s/EXPECT/ASSERT/
> >     
> >     as this is the last expectation in the test.
> 
> Marco Massenzio wrote:
>     LoL - I was doing some AngularJS unit testing the night before, the 
> `expect` must have gotten stuck in my head!

Well, we use EXPECT when the test can continue if the expectation fails, ASSERT 
when the test cannot proceed further: http://stackoverflow.com/a/2565309

But it's not that critical, pretty sure most tests are inconsistent about this.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815/#review89297
-----------------------------------------------------------


On June 25, 2015, 7:53 a.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35815/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 7:53 a.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2898
>     https://issues.apache.org/jira/browse/MESOS-2898
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> As of Mesos 0.24, we will support JSON format
> for the MasterInfo information written out to
> ZooKeeper for the Leader election process.
> 
> This tests that the JSON can be correctly parsed
> and the correct MasterInfo information retrieved.
> 
> Jira: MESOS-2898
> 
> 
> Diffs
> -----
> 
>   src/tests/master_contender_detector_tests.cpp 
> 1b30eeb51520da7a5834768ac88a88a8a84fd976 
> 
> Diff: https://reviews.apache.org/r/35815/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Reply via email to