> On June 25, 2015, 1:08 a.m., Ben Mahler wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 768
> > <https://reviews.apache.org/r/35836/diff/2/?file=991617#file991617line768>
> >
> >     Hm.. can you keep the available? I think we wanted this log line to 
> > help us know what will be offered next, but without the total we can't tell?
> >     
> >     ```
> >         Resources available = slaves[slaveId].total - 
> > slaves[slaveId].allocated;
> >     
> >         LOG(INFO) << "Recovered " << resources << " (available: " << 
> > available << ")"
> >                   << " on slave " << slaveId << " from framework " << 
> > frameworkId;
> >     ```
> >     
> >     Or if you wanted to see if it's over-allocated here, maybe we can print 
> > both?

I printed both.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35836/#review89289
-----------------------------------------------------------


On June 24, 2015, 9:53 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35836/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:53 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-2919
>     https://issues.apache.org/jira/browse/MESOS-2919
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaced slave's 'available' with 'allocated' in hierarchical allocator.
> 
> This is used to fix MESOS-2919. See ticket for details and motivation.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> ef18ff850addfb5ce3500ed28e8ffd801e2d24eb 
> 
> Diff: https://reviews.apache.org/r/35836/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to