----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/#review89871 -----------------------------------------------------------
Patch looks great! Reviews applied: [36036] All tests passed. - Mesos ReviewBot On June 30, 2015, 6:28 a.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36036/ > ----------------------------------------------------------- > > (Updated June 30, 2015, 6:28 a.m.) > > > Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Vinod Kone. > > > Bugs: MESOS-2957 > https://issues.apache.org/jira/browse/MESOS-2957 > > > Repository: mesos > > > Description > ------- > > Jira: MESOS-2957 > > Adds an optional version string to the `MasterInfo` protobuf, > to simplify handling versioning in HTTP API calls. > > The version string is taken from <mesos/version.hpp> which is the > same used when starting up Master (master/main.cpp). > > I've added a simple test on the back of the `MasterDetector` test, > as this was the place where we would expect the `MasterInfo` to > have been fully populated by real production code (as opposed to > other places, where it is actually handled by mocks). > > > Diffs > ----- > > include/mesos/mesos.proto 0ebe5d3a5ae033419482c28be80b09d277e0ff02 > src/common/protobuf_utils.cpp f0642ba12b914889a876d1d1c49a2c242006433c > src/common/type_utils.cpp f7b21c6abc392fec0514224ff02a00e772389f5d > src/tests/master_contender_detector_tests.cpp > d7a3b46b2e437818631064ae34317e49c9aa3748 > > Diff: https://reviews.apache.org/r/36036/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >