-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/#review90139
-----------------------------------------------------------



src/linux/cgroups.cpp (line 2002)
<https://reviews.apache.org/r/36106/#comment143124>

    We usually name the constructor params and the variables the same.



src/linux/cgroups.cpp (line 2014)
<https://reviews.apache.org/r/36106/#comment143120>

    I don't think we usually define a inline function like this anywhere else, 
so curious to see what others think.
    Personally I don't think it provides any additional benefits here.



src/linux/cgroups.cpp (line 2033)
<https://reviews.apache.org/r/36106/#comment143117>

    Space before



src/linux/cgroups.cpp (line 2042)
<https://reviews.apache.org/r/36106/#comment143118>

    Space before



src/linux/cgroups.cpp (line 2053)
<https://reviews.apache.org/r/36106/#comment143115>

    Add space before and after division operator.



src/linux/cgroups.cpp (line 2060)
<https://reviews.apache.org/r/36106/#comment143116>

    Why add trailing underscore?



src/tests/cgroups_tests.cpp (line 1192)
<https://reviews.apache.org/r/36106/#comment143122>

    Add using to the top of the tests



src/tests/cgroups_tests.cpp (line 1229)
<https://reviews.apache.org/r/36106/#comment143123>

    Space before and after division



src/tests/cgroups_tests.cpp (line 1246)
<https://reviews.apache.org/r/36106/#comment143121>

    Remove space


- Timothy Chen


On July 1, 2015, 9:38 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36106/
> -----------------------------------------------------------
> 
> (Updated July 1, 2015, 9:38 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> cgroups implementation does not have a cpuacct subsystem implementation as of
> today. Adding the implementation for stat function.
> 
> Changes:
>   - added Stats class to encapsulate cpuacct.stat data
>   - added implementation for cpuacct::stats
>   - added unit tests
> 
> Jira: MESOS-2961
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 73b98317880eea3d6a2ba37ac56d1f7e3600ba94 
>   src/linux/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00 
>   src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a 
> 
> Diff: https://reviews.apache.org/r/36106/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to