> On July 1, 2015, 9:46 p.m., Timothy Chen wrote: > > src/linux/cgroups.cpp, line 2060 > > <https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2060> > > > > Why add trailing underscore? > > Jojy Varghese wrote: > As a member variable(is accepted according to mesos coding style > guidelines) > > Timothy Chen wrote: > I don't see where in our mesos coding style guide specified this? > And if you look in the code base we only put trailing spaces if it > clashes with something else, but in this case we should prefer without. > > Jojy Varghese wrote: > In style guide (Variable naming section): > "Prefer trailing underscores for use as member fields (but not required)."
Hey Tim - this is a recent change, we discussed during a code review meeting. We now follow more closely the Google Style, by adding the trailing underscore on private variables. Check out the `FlagsBase` for an example of this. - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90139 ----------------------------------------------------------- On July 1, 2015, 9:38 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36106/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 9:38 p.m.) > > > Review request for mesos, Ian Downes, Joris Van Remoortere, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > cgroups implementation does not have a cpuacct subsystem implementation as of > today. Adding the implementation for stat function. > > Changes: > - added Stats class to encapsulate cpuacct.stat data > - added implementation for cpuacct::stats > - added unit tests > > Jira: MESOS-2961 > > > Diffs > ----- > > src/linux/cgroups.hpp 73b98317880eea3d6a2ba37ac56d1f7e3600ba94 > src/linux/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00 > src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a > > Diff: https://reviews.apache.org/r/36106/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
