----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/#review90177 -----------------------------------------------------------
src/tests/perf_tests.cpp (lines 76 - 84) <https://reviews.apache.org/r/36115/#comment143173> You're testing each version of parse here explicitly rather than testing that parse() does the right thing for different versions of input. I would construct different inputs corresponding to different perf versions and then verify that the *output* had the correct fields and values. src/tests/perf_tests.cpp (line 87) <https://reviews.apache.org/r/36115/#comment143172> ```cpp foreach (const tuple<Version, string>& input, input1) {} ```? - Ian Downes On July 1, 2015, 3:44 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36115/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 3:44 p.m.) > > > Review request for mesos, Ian Downes, Paul Brett, and Cong Wang. > > > Bugs: mesos-2834 > https://issues.apache.org/jira/browse/mesos-2834 > > > Repository: mesos > > > Description > ------- > > perf: changed 'parse' interface to allow testing and added tests. > > > Diffs > ----- > > src/linux/perf.hpp b77b61d7048b12cea4586bcf802cbc2ff634331b > src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 > src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 > > Diff: https://reviews.apache.org/r/36115/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
