> On July 1, 2015, 11:41 p.m., Paul Brett wrote:
> > src/tests/perf_tests.cpp, line 93
> > <https://reviews.apache.org/r/36115/diff/1/?file=997707#file997707line93>
> >
> >     ASSERT_SOME_TRUE

would need parse to be Try<bool> for it to compile.


- Chi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36115/#review90164
-----------------------------------------------------------


On July 2, 2015, 11:42 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36115/
> -----------------------------------------------------------
> 
> (Updated July 2, 2015, 11:42 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Paul Brett, and Cong Wang.
> 
> 
> Bugs: mesos-2834
>     https://issues.apache.org/jira/browse/mesos-2834
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> perf: changed 'parse' interface to allow testing and added tests.
> 
> 
> Diffs
> -----
> 
>   src/linux/perf.hpp b77b61d7048b12cea4586bcf802cbc2ff634331b 
>   src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 
>   src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 
> 
> Diff: https://reviews.apache.org/r/36115/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Reply via email to