----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36173/#review90445 -----------------------------------------------------------
docs/attributes-resources.md (line 35) <https://reviews.apache.org/r/36173/#comment143491> Doesn't `( scalar | range | text | "," )+` look like a set that doesn't wrap itself in `{}` braces? It doesn't look like Attributes::parse handles the "," case, so let's remove that (and the `()+`) from the documentation. - Adam B On July 3, 2015, 2:30 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36173/ > ----------------------------------------------------------- > > (Updated July 3, 2015, 2:30 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Repository: mesos > > > Description > ------- > > Update attributes doc to reflect current supported attributes types. > > > Diffs > ----- > > docs/attributes-resources.md 0ae8b5908fe0b3a3499e6d813afbb328a13bdcde > > Diff: https://reviews.apache.org/r/36173/diff/ > > > Testing > ------- > > make > > > Thanks, > > Timothy Chen > >
